cppcheck fixes

Author: robertosfield

cmake/cppcheck-suppression-list.txt

@@ -152,6 +152,7 @@ arrayIndexOutOfBounds:*/include/vsg/vk/State.h
 // suppress warnings about intentional code usage or where cppcheck just hasn't got a clue about how templates are used...
 knownConditionTrueFalse:*/src/vsg/utils/Builder.cpp
 knownConditionTrueFalse:*/include/vsg/utils/CommandLine.h
+knownConditionTrueFalse:*/include/vsg/utils/Inherit.h
 
 // suppress warning about initializtion.
 useInitializationList:*/include/vsg/core/ScratchMemory.h

include/vsg/core/IntrusiveAllocator.h

@@ -104,9 +104,13 @@ namespace vsg
                     next(static_cast<Offset>(in_next)),
                     status(in_status) {}
 
-                Element() = default;
-                Element(const Element&) = default;
-                Element& operator=(const Element&) = default;
+                Element() : index(0) {}
+                Element(const Element& rhs) : index(rhs.index) {}
+                Element& operator=(const Element& rhs)
+                {
+                    index = rhs.index;
+                    return *this;
+                }
             };
 
             struct FreeList

include/vsg/lighting/AmbientLight.h

@@ -33,7 +33,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~AmbientLight() {}
+        ~AmbientLight() override {}
     };
     VSG_type_name(vsg::AmbientLight);
 

include/vsg/lighting/DirectionalLight.h

@@ -37,7 +37,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~DirectionalLight() {}
+        ~DirectionalLight() override {}
     };
     VSG_type_name(vsg::DirectionalLight);
 

include/vsg/lighting/Light.h

@@ -41,7 +41,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~Light() {}
+        ~Light() override {}
     };
     VSG_type_name(vsg::Light);
 

include/vsg/lighting/PointLight.h

@@ -37,7 +37,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~PointLight() {}
+        ~PointLight() override {}
     };
     VSG_type_name(vsg::PointLight);
 

include/vsg/lighting/ShadowSettings.h

@@ -33,7 +33,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~ShadowSettings() {}
+        ~ShadowSettings() override {}
     };
     VSG_type_name(vsg::ShadowSettings);
 

include/vsg/lighting/SpotLight.h

@@ -40,7 +40,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~SpotLight() {}
+        ~SpotLight() override {}
     };
     VSG_type_name(vsg::SpotLight);
 

include/vsg/raytracing/AccelerationStructure.h

@@ -37,7 +37,7 @@ namespace vsg
         VkDeviceSize requiredScratchSize() const { return _requiredBuildScratchSize; }
 
     protected:
-        virtual ~AccelerationStructure();
+        ~AccelerationStructure() override;
 
         VkAccelerationStructureKHR _accelerationStructure;
         VkAccelerationStructureCreateInfoKHR _accelerationStructureInfo;

include/vsg/raytracing/RayTracingPipeline.h

@@ -56,12 +56,12 @@ namespace vsg
         VkPipeline vk(uint32_t deviceID) const { return _implementation[deviceID]->_pipeline; }
 
     protected:
-        virtual ~RayTracingPipeline();
+        ~RayTracingPipeline() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
             Implementation(Context& context, RayTracingPipeline* rayTracingPipeline);
-            virtual ~Implementation();
+            ~Implementation() override;
 
             VkPipeline _pipeline;
 
@@ -103,7 +103,7 @@ namespace vsg
         virtual void release();
 
     public:
-        virtual ~BindRayTracingPipeline();
+        ~BindRayTracingPipeline() override;
 
         ref_ptr<RayTracingPipeline> _pipeline;
     };