cppcheck fixes

robertosfield · robertosfield · commit 5ef2fe24d24d · 2026-05-08T13:57:16.000+01:00
diff --git a/include/vsg/state/ArrayState.h b/include/vsg/state/ArrayState.h
@@ -92,7 +92,7 @@ namespace vsg
         virtual ref_ptr<const vec3Array> vertexArray(uint32_t instanceIndex);
 
     protected:
-        virtual ~ArrayState() {}
+        ~ArrayState() override {}
     };
     VSG_type_name(vsg::ArrayState);
 
diff --git a/include/vsg/state/BindDescriptorSet.h b/include/vsg/state/BindDescriptorSet.h
@@ -74,7 +74,7 @@ namespace vsg
         void record(CommandBuffer& commandBuffer) const override;
 
     protected:
-        virtual ~BindDescriptorSets() {}
+        ~BindDescriptorSets() override {}
 
         struct VulkanData
         {
diff --git a/include/vsg/state/Buffer.h b/include/vsg/state/Buffer.h
@@ -60,7 +60,7 @@ namespace vsg
         virtual bool compile(Context& context);
 
     protected:
-        virtual ~Buffer();
+        ~Buffer() override;
 
         struct VulkanData
         {
diff --git a/include/vsg/state/BufferInfo.h b/include/vsg/state/BufferInfo.h
@@ -74,7 +74,7 @@ namespace vsg
         vk_buffer<ModifiedCount> copiedModifiedCounts;
 
     protected:
-        virtual ~BufferInfo();
+        ~BufferInfo() override;
     };
     VSG_type_name(vsg::BufferInfo);
 
diff --git a/include/vsg/state/BufferView.h b/include/vsg/state/BufferView.h
@@ -42,7 +42,7 @@ namespace vsg
         virtual void compile(Context& context);
 
     protected:
-        virtual ~BufferView();
+        ~BufferView() override;
 
         struct VulkanData
         {
diff --git a/include/vsg/state/ColorBlendState.h b/include/vsg/state/ColorBlendState.h
@@ -44,7 +44,7 @@ namespace vsg
         void apply(Context& context, VkGraphicsPipelineCreateInfo& pipelineInfo) const override;
 
     protected:
-        virtual ~ColorBlendState();
+        ~ColorBlendState() override;
     };
     VSG_type_name(vsg::ColorBlendState);
 
diff --git a/include/vsg/state/ComputePipeline.h b/include/vsg/state/ComputePipeline.h
@@ -45,7 +45,7 @@ namespace vsg
         VkPipeline vk(uint32_t deviceID) const { return _implementation[deviceID]->_pipeline; }
 
     protected:
-        virtual ~ComputePipeline();
+        ~ComputePipeline() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
@@ -80,7 +80,7 @@ namespace vsg
         void compile(Context& context) override;
 
     public:
-        virtual ~BindComputePipeline();
+        ~BindComputePipeline() override;
     };
     VSG_type_name(vsg::BindComputePipeline);
 
diff --git a/include/vsg/state/DepthStencilState.h b/include/vsg/state/DepthStencilState.h
@@ -43,7 +43,7 @@ namespace vsg
         void apply(Context& context, VkGraphicsPipelineCreateInfo& pipelineInfo) const override;
 
     protected:
-        virtual ~DepthStencilState();
+        ~DepthStencilState() override;
     };
     VSG_type_name(vsg::DepthStencilState);
 
diff --git a/include/vsg/state/DescriptorBuffer.h b/include/vsg/state/DescriptorBuffer.h
@@ -46,7 +46,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~DescriptorBuffer();
+        ~DescriptorBuffer() override;
     };
     VSG_type_name(vsg::DescriptorBuffer)
 
diff --git a/include/vsg/state/DescriptorSet.h b/include/vsg/state/DescriptorSet.h
@@ -85,7 +85,7 @@ namespace vsg
         };
 
     protected:
-        virtual ~DescriptorSet();
+        ~DescriptorSet() override;
 
         vk_buffer<ref_ptr<Implementation>> _implementation;
     };
diff --git a/include/vsg/state/DescriptorSetLayout.h b/include/vsg/state/DescriptorSetLayout.h
@@ -64,7 +64,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~DescriptorSetLayout();
+        ~DescriptorSetLayout() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
diff --git a/include/vsg/state/DynamicState.h b/include/vsg/state/DynamicState.h
@@ -46,7 +46,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~DynamicState();
+        ~DynamicState() override;
     };
     VSG_type_name(vsg::DynamicState);
 
diff --git a/include/vsg/state/GraphicsPipeline.h b/include/vsg/state/GraphicsPipeline.h
@@ -44,7 +44,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~GraphicsPipelineState() {}
+        ~GraphicsPipelineState() override {}
     };
     VSG_type_name(vsg::GraphicsPipelineState);
 
@@ -88,7 +88,7 @@ namespace vsg
         void release() { _implementation.clear(); }
 
     protected:
-        virtual ~GraphicsPipeline();
+        ~GraphicsPipeline() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
diff --git a/include/vsg/state/Image.h b/include/vsg/state/Image.h
@@ -72,7 +72,7 @@ namespace vsg
         virtual VkResult compile(MemoryBufferPools& memoryBufferPools);
 
     protected:
-        virtual ~Image();
+        ~Image() override;
 
         struct VulkanData
         {
diff --git a/include/vsg/state/ImageInfo.h b/include/vsg/state/ImageInfo.h
@@ -69,7 +69,7 @@ namespace vsg
         vk_buffer<ModifiedCount> copiedModifiedCounts;
 
     protected:
-        virtual ~ImageInfo();
+        ~ImageInfo() override;
     };
     VSG_type_name(vsg::ImageInfo);
 
diff --git a/include/vsg/state/ImageView.h b/include/vsg/state/ImageView.h
@@ -44,7 +44,7 @@ namespace vsg
         virtual void compile(Context& context);
 
     protected:
-        virtual ~ImageView();
+        ~ImageView() override;
 
         struct VulkanData
         {
diff --git a/include/vsg/state/InputAssemblyState.h b/include/vsg/state/InputAssemblyState.h
@@ -35,7 +35,7 @@ namespace vsg
         void apply(Context& context, VkGraphicsPipelineCreateInfo& pipelineInfo) const override;
 
     protected:
-        virtual ~InputAssemblyState();
+        ~InputAssemblyState() override;
     };
     VSG_type_name(vsg::InputAssemblyState);
 
diff --git a/include/vsg/state/MultisampleState.h b/include/vsg/state/MultisampleState.h
@@ -38,7 +38,7 @@ namespace vsg
         void apply(Context& context, VkGraphicsPipelineCreateInfo& pipelineInfo) const override;
 
     protected:
-        virtual ~MultisampleState();
+        ~MultisampleState() override;
     };
     VSG_type_name(vsg::MultisampleState);
 
diff --git a/include/vsg/state/PipelineLayout.h b/include/vsg/state/PipelineLayout.h
@@ -54,7 +54,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~PipelineLayout();
+        ~PipelineLayout() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
diff --git a/include/vsg/state/PushConstants.h b/include/vsg/state/PushConstants.h
@@ -37,7 +37,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~PushConstants();
+        ~PushConstants() override;
     };
     VSG_type_name(vsg::PushConstants);
 
diff --git a/include/vsg/state/RasterizationState.h b/include/vsg/state/RasterizationState.h
@@ -45,7 +45,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~RasterizationState();
+        ~RasterizationState() override;
     };
     VSG_type_name(vsg::RasterizationState);
 
diff --git a/include/vsg/state/ResourceHints.h b/include/vsg/state/ResourceHints.h
@@ -92,7 +92,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~ResourceHints();
+        ~ResourceHints() override;
     };
     VSG_type_name(vsg::ResourceHints);
 
diff --git a/include/vsg/state/Sampler.h b/include/vsg/state/Sampler.h
@@ -59,7 +59,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~Sampler();
+        ~Sampler() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
diff --git a/include/vsg/state/ShaderModule.h b/include/vsg/state/ShaderModule.h
@@ -105,7 +105,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~ShaderModule();
+        ~ShaderModule() override;
 
         struct Implementation : public Inherit<Object, Implementation>
         {
diff --git a/include/vsg/state/ShaderStage.h b/include/vsg/state/ShaderStage.h
@@ -58,7 +58,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~ShaderStage();
+        ~ShaderStage() override;
     };
     VSG_type_name(vsg::ShaderStage);
 
diff --git a/include/vsg/state/StateCommand.h b/include/vsg/state/StateCommand.h
@@ -36,7 +36,7 @@ namespace vsg
         uint32_t slot = 0;
 
     protected:
-        virtual ~StateCommand() {}
+        ~StateCommand() override {}
     };
     VSG_type_name(vsg::StateCommand);
 
diff --git a/include/vsg/state/TessellationState.h b/include/vsg/state/TessellationState.h
@@ -36,7 +36,7 @@ namespace vsg
         void apply(Context& context, VkGraphicsPipelineCreateInfo& pipelineInfo) const override;
 
     protected:
-        virtual ~TessellationState();
+        ~TessellationState() override;
     };
     VSG_type_name(vsg::TessellationState);
 
diff --git a/include/vsg/state/VertexInputState.h b/include/vsg/state/VertexInputState.h
@@ -40,7 +40,7 @@ namespace vsg
         void apply(Context& context, VkGraphicsPipelineCreateInfo& pipelineInfo) const override;
 
     protected:
-        virtual ~VertexInputState();
+        ~VertexInputState() override;
     };
     VSG_type_name(vsg::VertexInputState);
 
diff --git a/include/vsg/state/ViewDependentState.h b/include/vsg/state/ViewDependentState.h
@@ -88,7 +88,7 @@ namespace vsg
         void record(CommandBuffer& commandBuffer) const override;
 
     protected:
-        virtual ~BindViewDescriptorSets() {}
+        ~BindViewDescriptorSets() override {}
     };
     VSG_type_name(vsg::BindViewDescriptorSets);
 
diff --git a/include/vsg/state/ViewportState.h b/include/vsg/state/ViewportState.h
@@ -55,7 +55,7 @@ namespace vsg
         void record(CommandBuffer& commandBuffer) const override;
 
     protected:
-        virtual ~ViewportState();
+        ~ViewportState() override;
     };
     VSG_type_name(vsg::ViewportState);
 

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ namespace vsg`
`74`	`74`	`void record(CommandBuffer& commandBuffer) const override;`
`75`	`75`
`76`	`76`	`protected:`
`77`		`- virtual ~BindDescriptorSets() {}`
	`77`	`+ ~BindDescriptorSets() override {}`
`78`	`78`
`79`	`79`	`struct VulkanData`
`80`	`80`	`{`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ namespace vsg`
`60`	`60`	`virtual bool compile(Context& context);`
`61`	`61`
`62`	`62`	`protected:`
`63`		`- virtual ~Buffer();`
	`63`	`+ ~Buffer() override;`
`64`	`64`
`65`	`65`	`struct VulkanData`
`66`	`66`	`{`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ namespace vsg`
`42`	`42`	`virtual void compile(Context& context);`
`43`	`43`
`44`	`44`	`protected:`
`45`		`- virtual ~BufferView();`
	`45`	`+ ~BufferView() override;`
`46`	`46`
`47`	`47`	`struct VulkanData`
`48`	`48`	`{`