cppcheck fixes

Author: robertosfield

include/vsg/commands/Event.h

@@ -57,7 +57,7 @@ namespace vsg
         void record(CommandBuffer& commandBuffer) const override;
 
     protected:
-        virtual ~SetEvent();
+        ~SetEvent() override;
     };
     VSG_type_name(vsg::SetEvent);
 
@@ -73,7 +73,7 @@ namespace vsg
         void record(CommandBuffer& commandBuffer) const override;
 
     protected:
-        virtual ~ResetEvent();
+        ~ResetEvent() override;
     };
     VSG_type_name(vsg::ResetEvent);
 
@@ -107,7 +107,7 @@ namespace vsg
         ImageMemoryBarriers imageMemoryBarriers;
 
     protected:
-        virtual ~WaitEvents();
+        ~WaitEvents() override;
     };
     VSG_type_name(vsg::WaitEvents);
 

include/vsg/core/External.h

@@ -59,7 +59,7 @@ namespace vsg
         void add(const Path& filename, ref_ptr<Object> object = {}) { entries[filename] = object; }
 
     protected:
-        virtual ~External();
+        ~External() override;
     };
     VSG_type_name(vsg::External);
 

include/vsg/core/IntrusiveAllocator.h

@@ -48,7 +48,7 @@ namespace vsg
         explicit IntrusiveAllocator(size_t in_defaultAlignment = 8);
         explicit IntrusiveAllocator(std::unique_ptr<Allocator> in_nestedAllocator, size_t in_defaultAlignment = 8);
 
-        ~IntrusiveAllocator();
+        ~IntrusiveAllocator() override;
 
         void report(std::ostream& out) const override;
 

include/vsg/core/MipmapLayout.h

@@ -47,7 +47,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~MipmapLayout();
+        ~MipmapLayout() override;
     };
     VSG_type_name(vsg::MipmapLayout);
 

include/vsg/core/Objects.h

@@ -48,7 +48,7 @@ namespace vsg
         }
 
     protected:
-        virtual ~Objects();
+        ~Objects() override;
     };
     VSG_type_name(vsg::Objects);
 

include/vsg/state/QueryPool.h

@@ -51,7 +51,7 @@ namespace vsg
         void compile(Context& context);
 
     protected:
-        ~QueryPool();
+        ~QueryPool() override;
 
         VkQueryPool _queryPool{};
         ref_ptr<Device> _device{};

src/vsg/utils/PolytopeIntersector.cpp

@@ -220,15 +220,15 @@ PolytopeIntersector::PolytopeIntersector(const Camera& camera, double xMin, doub
     clipspace.push_back(dplane(0.0, 0.0, 1.0, ndc_far));   // far
 
     vsg::Polytope eyespace;
-    for (auto& pl : clipspace)
+    for (const auto& pl : clipspace)
     {
         eyespace.push_back(pl * projectionMatrix);
     }
 
     _polytopeStack.push_back(eyespace);
 
     vsg::Polytope worldspace;
-    for (auto& pl : eyespace)
+    for (const auto& pl : eyespace)
     {
         worldspace.push_back(pl * viewMatrix);
     }
@@ -276,7 +276,7 @@ void PolytopeIntersector::pushTransform(const Transform& transform)
     const auto& worldspace = _polytopeStack.front();
 
     Polytope localspace;
-    for (auto& pl : worldspace)
+    for (const auto& pl : worldspace)
     {
         localspace.push_back(pl * localToWorld);
     }