Skip to content

Commit abc52dc

Browse files
committed
cppcheck fixes
1 parent afa8ae3 commit abc52dc

17 files changed

Lines changed: 19 additions & 20 deletions

include/vsg/vk/AllocationCallbacks.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace vsg
2727
VkAllocationCallbacks{} {}
2828

2929
protected:
30-
virtual ~AllocationCallbacks() {}
30+
~AllocationCallbacks() override {}
3131
};
3232

3333
/*

include/vsg/vk/CommandBuffer.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ namespace vsg
6666
friend CommandPool;
6767
CommandBuffer(CommandPool* commandPool, VkCommandBuffer commandBuffer, VkCommandBufferLevel level);
6868

69-
virtual ~CommandBuffer();
69+
~CommandBuffer() override;
7070

7171
VkCommandBuffer _commandBuffer;
7272
VkCommandBufferLevel _level;
@@ -94,7 +94,7 @@ namespace vsg
9494
CommandBuffers buffers() const;
9595

9696
protected:
97-
virtual ~RecordedCommandBuffers();
97+
~RecordedCommandBuffers();
9898
mutable std::mutex _mutex;
9999
std::map<int, ref_ptr<RecordedCommandBuffers>> _orderedCommandBuffers;
100100
CommandBuffers _commandBuffers;

include/vsg/vk/CommandPool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ namespace vsg
4141
const Device* getDevice() const { return _device; }
4242

4343
protected:
44-
virtual ~CommandPool();
44+
~CommandPool() override;
4545

4646
friend CommandBuffer;
4747

include/vsg/vk/Context.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ namespace vsg
7070

7171
Context(const Context& context);
7272

73-
virtual ~Context();
73+
~Context() override;
7474

7575
const uint32_t deviceID = 0;
7676
ref_ptr<Device> device;

include/vsg/vk/DescriptorPool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ namespace vsg
5454
mutable std::mutex mutex;
5555

5656
protected:
57-
virtual ~DescriptorPool();
57+
~DescriptorPool() override;
5858

5959
VkDescriptorPool _descriptorPool;
6060
ref_ptr<Device> _device;

include/vsg/vk/DescriptorPools.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ namespace vsg
5656
bool allocated(uint32_t& numSets, DescriptorPoolSizes& descriptorPoolSizes) const;
5757

5858
protected:
59-
virtual ~DescriptorPools();
59+
~DescriptorPools() override;
6060

6161
/// get the maxSets and descriptorPoolSizes to use
6262
void getDescriptorPoolSizesToUse(uint32_t& maxSets, DescriptorPoolSizes& descriptorPoolSizes);

include/vsg/vk/Device.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ namespace vsg
9595
observer_ptr<TransferTask> transferTask;
9696

9797
protected:
98-
virtual ~Device();
98+
~Device() override;
9999

100100
VkDevice _device;
101101

include/vsg/vk/DeviceMemory.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ namespace vsg
5959
void report(LogOutput& out) const;
6060

6161
protected:
62-
virtual ~DeviceMemory();
62+
~DeviceMemory() override;
6363

6464
VkDeviceMemory _deviceMemory;
6565
VkMemoryRequirements _memoryRequirements;
@@ -105,7 +105,7 @@ namespace vsg
105105
return data;
106106
}
107107

108-
virtual ~MappedData()
108+
~MappedData() override
109109
{
110110
T::dataRelease(); // make sure that the Array doesn't delete this memory
111111
_deviceMemory->unmap();

include/vsg/vk/Fence.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ namespace vsg
4444
const Device* getDevice() const { return _device; }
4545

4646
protected:
47-
virtual ~Fence();
47+
~Fence() override;
4848

4949
VkFence _vkFence;
5050
Semaphores _dependentSemaphores;

include/vsg/vk/Framebuffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ namespace vsg
4343
VkExtent2D extent2D() const { return VkExtent2D{_width, _height}; }
4444

4545
protected:
46-
virtual ~Framebuffer();
46+
~Framebuffer() override;
4747

4848
VkFramebuffer _framebuffer;
4949
ref_ptr<Device> _device;

0 commit comments

Comments
 (0)