Merge pull request #1706 from vsg-dev/cppcheck_fixes

Mostly cppcheck warning fixes with a couple of bugs fixed.

Author: robertosfield

CMakeLists.txt

@@ -5,7 +5,7 @@ project(vsg
     DESCRIPTION "VulkanSceneGraph library"
     LANGUAGES CXX
 )
-set(VSG_SOVERSION 16)
+set(VSG_SOVERSION 17)
 SET(VSG_RELEASE_CANDIDATE 0)
 set(Vulkan_MIN_VERSION 1.1.70.0)
 

cmake/cppcheck-suppression-list.txt

@@ -152,6 +152,7 @@ arrayIndexOutOfBounds:*/include/vsg/vk/State.h
 // suppress warnings about intentional code usage or where cppcheck just hasn't got a clue about how templates are used...
 knownConditionTrueFalse:*/src/vsg/utils/Builder.cpp
 knownConditionTrueFalse:*/include/vsg/utils/CommandLine.h
+knownConditionTrueFalse:*/include/vsg/core/Inherit.h
 
 // suppress warning about initializtion.
 useInitializationList:*/include/vsg/core/ScratchMemory.h
@@ -223,6 +224,11 @@ cstyleCast:*/src/vsg/io/mem_stream.cpp
 
 // suppress unhelpful warnings of override that make inform programmers what is being done
 uselessOverride:*/include/vsg/utils/TracyInstrumentation.h
+uselessOverride:*/include/vsg/ui/WindowEvent.h
+uselessOverride:*/include/vsg/utils/ShaderSet.h
+uselessOverride:*/include/vsg/nodes/Transform.h
+uselessOverride:*/include/vsg/raytracing/DescriptorAccelerationStructure.h
+uselessOverride:*/include/vsg/raytracing/RayTracingShaderGroup.h
 
 // suppress inappropriate warning
 constParameterReference:*/include/vsg/vk/Device.h
@@ -242,3 +248,22 @@ constVariablePointer:*/src/vsg/app/SecondaryCommandGraph.cpp
 // suppress inappropriate warning
 passedByValue:*/src/vsg/vk/Device.cpp
 passedByValue:*/src/vsg/vk/Instance.cpp
+
+// suppress inappropriate warnings
+functionStatic:*/include/vsg/io/Output.h
+functionStatic:*/include/vsg/io/Input.h
+functionStatic:*/src/vsg/app/CompileManager.h
+functionStatic:*/include/vsg/app/RecordTraversal.h
+functionStatic:*/include/vsg/io/VSG.h
+functionStatic:*/include/vsg/io/json.h
+functionStatic:*/include/vsg/io/txt.h
+functionStatic:*/include/vsg/io/tile.h
+functionStatic:*/include/vsg/state/QueryPool.h
+functionStatic:*/include/vsg/state/ArrayState.h
+functionStatic:*/include/vsg/text/StandardLayout.h
+functionStatic:*/include/vsg/utils/Builder.h
+functionStatic:*/include/vsg/utils/ShaderCompiler.h
+
+
+// suppress inappropriate warnings
+suspiciousFloatingPointCast:*/src/vsg/maths/maths_transform.cpp

include/vsg/animation/AnimationGroup.h

@@ -50,7 +50,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~AnimationGroup();
+        ~AnimationGroup() override;
     };
     VSG_type_name(vsg::AnimationGroup);
 

include/vsg/animation/Joint.h

@@ -54,7 +54,7 @@ namespace vsg
         void write(Output& output) const override;
 
     protected:
-        virtual ~Joint();
+        ~Joint() override;
     };
     VSG_type_name(vsg::Joint);
 

include/vsg/app/CommandGraph.h

@@ -54,7 +54,7 @@ namespace vsg
         ref_ptr<Instrumentation> instrumentation;
 
     protected:
-        virtual ~CommandGraph();
+        ~CommandGraph() override;
 
         CommandBuffers _commandBuffers; // assign one per index? Or just use round robin, each has a CommandPool
     };

include/vsg/app/CompileManager.h

@@ -91,7 +91,7 @@ namespace vsg
         std::atomic_uint failedCompileCount{0};
 
     protected:
-        ~CompileManager();
+        ~CompileManager() override;
 
         using CompileTraversals = ThreadSafeQueue<ref_ptr<CompileTraversal>>;
         size_t numCompileTraversals = 0;

include/vsg/app/CompileTraversal.h

@@ -103,7 +103,7 @@ namespace vsg
         void apply(View& view) override;
 
     protected:
-        ~CompileTraversal();
+        ~CompileTraversal() override;
 
         void add(ref_ptr<Context> context, Framebuffer& framebuffer, ref_ptr<TransferTask> transferTask, ref_ptr<View> view, const ResourceRequirements& resourceRequirements);
         void addViewDependentState(ViewDependentState& viewDependentState, ref_ptr<Device> device, ref_ptr<TransferTask> transferTask, const ResourceRequirements& resourceRequirements);

include/vsg/app/RecordTraversal.h

@@ -185,7 +185,7 @@ namespace vsg
         ref_ptr<ViewDependentState> viewDependentState;
 
     protected:
-        virtual ~RecordTraversal();
+        ~RecordTraversal() override;
     };
 
 } // namespace vsg

include/vsg/app/SecondaryCommandGraph.h

@@ -43,7 +43,7 @@ namespace vsg
         void record(ref_ptr<RecordedCommandBuffers> recordedCommandBuffers, ref_ptr<FrameStamp> frameStamp = {}, ref_ptr<DatabasePager> databasePager = {}) override;
 
     protected:
-        virtual ~SecondaryCommandGraph();
+        ~SecondaryCommandGraph() override;
 
         friend ExecuteCommands;
 

include/vsg/app/UpdateOperations.h

@@ -55,7 +55,7 @@ namespace vsg
         virtual void run();
 
     protected:
-        virtual ~UpdateOperations();
+        ~UpdateOperations() override;
 
         mutable std::mutex _updateOperationMutex;
         std::list<ref_ptr<Operation>> _updateOperationsOneTime;