cppcheck fixes

Author: robertosfield

cmake/cppcheck-suppression-list.txt

@@ -224,6 +224,11 @@ cstyleCast:*/src/vsg/io/mem_stream.cpp
 
 // suppress unhelpful warnings of override that make inform programmers what is being done
 uselessOverride:*/include/vsg/utils/TracyInstrumentation.h
+uselessOverride:*/include/vsg/ui/WindowEvent.h
+uselessOverride:*/include/vsg/utils/ShaderSet.h
+uselessOverride:*/include/vsg/nodes/Transform.h
+uselessOverride:*/include/vsg/raytracing/DescriptorAccelerationStructure.h
+uselessOverride:*/include/vsg/raytracing/RayTracingShaderGroup.h
 
 // suppress inappropriate warning
 constParameterReference:*/include/vsg/vk/Device.h
@@ -258,8 +263,6 @@ functionStatic:*/include/vsg/state/ArrayState.h
 functionStatic:*/include/vsg/text/StandardLayout.h
 functionStatic:*/include/vsg/utils/Builder.h
 functionStatic:*/include/vsg/utils/ShaderCompiler.h
-functionStatic:*/
-functionStatic:*/
 
 
 // suppress inappropriate warnings

include/vsg/lighting/AmbientLight.h

@@ -29,9 +29,6 @@ namespace vsg
     public:
         ref_ptr<Object> clone(const CopyOp& copyop = {}) const override { return AmbientLight::create(*this, copyop); }
 
-        void read(Input& input) override;
-        void write(Output& output) const override;
-
     protected:
         ~AmbientLight() override {}
     };

include/vsg/lighting/HardShadows.h

@@ -25,10 +25,6 @@ namespace vsg
 
     public:
         ref_ptr<Object> clone(const CopyOp& copyop = {}) const override { return HardShadows::create(*this, copyop); }
-        int compare(const Object& rhs) const override;
-
-        void read(Input& input) override;
-        void write(Output& output) const override;
     };
     VSG_type_name(vsg::HardShadows);
 

include/vsg/lighting/PercentageCloserSoftShadows.h

@@ -25,10 +25,6 @@ namespace vsg
 
     public:
         ref_ptr<Object> clone(const CopyOp& copyop = {}) const override { return PercentageCloserSoftShadows::create(*this, copyop); }
-        int compare(const Object& rhs) const override;
-
-        void read(Input& input) override;
-        void write(Output& output) const override;
     };
     VSG_type_name(vsg::PercentageCloserSoftShadows);
 

src/vsg/lighting/AmbientLight.cpp

@@ -22,13 +22,3 @@ AmbientLight::AmbientLight(const AmbientLight& rhs, const CopyOp& copyop) :
     Inherit(rhs, copyop)
 {
 }
-
-void AmbientLight::read(Input& input)
-{
-    Light::read(input);
-}
-
-void AmbientLight::write(Output& output) const
-{
-    Light::write(output);
-}

src/vsg/lighting/HardShadows.cpp

@@ -23,18 +23,3 @@ HardShadows::HardShadows(const HardShadows& rhs, const CopyOp& copyop) :
     Inherit(rhs, copyop)
 {
 }
-
-int HardShadows::compare(const Object& rhs_object) const
-{
-    return ShadowSettings::compare(rhs_object);
-}
-
-void HardShadows::read(Input& input)
-{
-    ShadowSettings::read(input);
-}
-
-void HardShadows::write(Output& output) const
-{
-    ShadowSettings::write(output);
-}

src/vsg/lighting/PercentageCloserSoftShadows.cpp

@@ -23,18 +23,3 @@ PercentageCloserSoftShadows::PercentageCloserSoftShadows(const PercentageCloserS
     Inherit(rhs, copyop)
 {
 }
-
-int PercentageCloserSoftShadows::compare(const Object& rhs_object) const
-{
-    return ShadowSettings::compare(rhs_object);
-}
-
-void PercentageCloserSoftShadows::read(Input& input)
-{
-    ShadowSettings::read(input);
-}
-
-void PercentageCloserSoftShadows::write(Output& output) const
-{
-    ShadowSettings::write(output);
-}

src/vsg/meshshaders/DrawMeshTasks.cpp

@@ -43,7 +43,7 @@ void DrawMeshTasks::write(Output& output) const
 
 void DrawMeshTasks::record(vsg::CommandBuffer& commandBuffer) const
 {
-    Device* device = commandBuffer.getDevice();
+    auto device = commandBuffer.getDevice();
     auto extensions = device->getExtensions();
     extensions->vkCmdDrawMeshTasksEXT(commandBuffer, groupCountX, groupCountY, groupCountZ);
 }

src/vsg/meshshaders/DrawMeshTasksIndirect.cpp

@@ -72,7 +72,7 @@ void DrawMeshTasksIndirect::compile(Context& context)
 
 void DrawMeshTasksIndirect::record(vsg::CommandBuffer& commandBuffer) const
 {
-    Device* device = commandBuffer.getDevice();
+    auto device = commandBuffer.getDevice();
     auto extensions = device->getExtensions();
     extensions->vkCmdDrawMeshTasksIndirectEXT(commandBuffer, drawParameters->buffer->vk(commandBuffer.deviceID), drawParameters->offset, drawCount, stride);
 }

src/vsg/meshshaders/DrawMeshTasksIndirectCount.cpp

@@ -83,7 +83,7 @@ void DrawMeshTasksIndirectCount::compile(Context& context)
 
 void DrawMeshTasksIndirectCount::record(vsg::CommandBuffer& commandBuffer) const
 {
-    Device* device = commandBuffer.getDevice();
+    auto device = commandBuffer.getDevice();
     auto extensions = device->getExtensions();
     extensions->vkCmdDrawMeshTasksIndirectCountEXT(commandBuffer, drawParameters->buffer->vk(commandBuffer.deviceID), drawParameters->offset, drawCount->buffer->vk(commandBuffer.deviceID), drawCount->offset, maxDrawCount, stride);
 }