cppcheck fixes

robertosfield · robertosfield · commit fde64f46b691 · 2026-05-08T12:37:32.000+01:00
diff --git a/include/vsg/core/Array.h b/include/vsg/core/Array.h
@@ -57,12 +57,12 @@ namespace vsg
             dirty();
         }
 
-        explicit Array(uint32_t numElements, Properties in_properties = {}) :
+        explicit Array(uint32_t numElements, const Properties& in_properties = {}) :
             Data(in_properties, sizeof(value_type)),
             _data(_allocate(numElements)),
             _size(numElements) { dirty(); }
 
-        Array(uint32_t numElements, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
+        Array(uint32_t numElements, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
             Data(in_properties, sizeof(value_type)),
             _data(data),
             _size(numElements)
@@ -71,7 +71,7 @@ namespace vsg
             dirty();
         }
 
-        Array(uint32_t numElements, const value_type& value, Properties in_properties = {}) :
+        Array(uint32_t numElements, const value_type& value, const Properties& in_properties = {}) :
             Data(in_properties, sizeof(value_type)),
             _data(_allocate(numElements)),
             _size(numElements)
@@ -80,7 +80,7 @@ namespace vsg
             dirty();
         }
 
-        Array(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t numElements, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
+        Array(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t numElements, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
             Data(),
             _data(nullptr),
             _size(0)
@@ -247,7 +247,7 @@ namespace vsg
             return *this;
         }
 
-        void assign(uint32_t numElements, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
+        void assign(uint32_t numElements, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
         {
             _delete();
 
@@ -262,7 +262,7 @@ namespace vsg
             dirty();
         }
 
-        void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t numElements, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
+        void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t numElements, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
         {
             _delete();
 
diff --git a/include/vsg/core/Array2D.h b/include/vsg/core/Array2D.h
@@ -57,7 +57,7 @@ namespace vsg
             }
         }
 
-        Array2D(uint32_t width, uint32_t height, Properties in_properties = {}) :
+        Array2D(uint32_t width, uint32_t height, const Properties& in_properties = {}) :
             Data(in_properties, sizeof(value_type)),
             _data(nullptr),
             _width(width),
@@ -67,7 +67,7 @@ namespace vsg
             dirty();
         }
 
-        Array2D(uint32_t width, uint32_t height, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
+        Array2D(uint32_t width, uint32_t height, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
             Data(in_properties, sizeof(value_type)),
             _data(data),
             _width(width),
@@ -77,7 +77,7 @@ namespace vsg
             dirty();
         }
 
-        Array2D(uint32_t width, uint32_t height, const value_type& value, Properties in_properties = {}) :
+        Array2D(uint32_t width, uint32_t height, const value_type& value, const Properties& in_properties = {}) :
             Data(in_properties, sizeof(value_type)),
             _data(nullptr),
             _width(width),
@@ -91,7 +91,7 @@ namespace vsg
             }
         }
 
-        Array2D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
+        Array2D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
             Data(),
             _data(nullptr),
             _width(0),
@@ -231,7 +231,7 @@ namespace vsg
             return *this;
         }
 
-        void assign(uint32_t width, uint32_t height, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
+        void assign(uint32_t width, uint32_t height, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
         {
             _delete();
 
@@ -247,7 +247,7 @@ namespace vsg
             dirty();
         }
 
-        void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
+        void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
         {
             _delete();
 
diff --git a/include/vsg/core/Array3D.h b/include/vsg/core/Array3D.h
@@ -59,7 +59,7 @@ namespace vsg
             }
         }
 
-        Array3D(uint32_t width, uint32_t height, uint32_t depth, Properties in_properties = {}) :
+        Array3D(uint32_t width, uint32_t height, uint32_t depth, const Properties& in_properties = {}) :
             Data(in_properties, sizeof(value_type)),
             _data(nullptr),
             _width(width),
@@ -70,7 +70,7 @@ namespace vsg
             dirty();
         }
 
-        Array3D(uint32_t width, uint32_t height, uint32_t depth, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
+        Array3D(uint32_t width, uint32_t height, uint32_t depth, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
             Data(in_properties, sizeof(value_type)),
             _data(data),
             _width(width),
@@ -81,7 +81,7 @@ namespace vsg
             dirty();
         }
 
-        Array3D(uint32_t width, uint32_t height, uint32_t depth, const value_type& value, Properties in_properties = {}) :
+        Array3D(uint32_t width, uint32_t height, uint32_t depth, const value_type& value, const Properties& in_properties = {}) :
             Data(in_properties, sizeof(value_type)),
             _data(nullptr),
             _width(width),
@@ -96,7 +96,7 @@ namespace vsg
             }
         }
 
-        Array3D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
+        Array3D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :
             Data(),
             _data(nullptr),
             _width(0),
@@ -242,7 +242,7 @@ namespace vsg
             return *this;
         }
 
-        void assign(uint32_t width, uint32_t height, uint32_t depth, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
+        void assign(uint32_t width, uint32_t height, uint32_t depth, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
         {
             _delete();
 
@@ -259,7 +259,7 @@ namespace vsg
             dirty();
         }
 
-        void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
+        void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)
         {
             _delete();
 
diff --git a/include/vsg/core/Data.h b/include/vsg/core/Data.h
@@ -144,10 +144,10 @@ namespace vsg
         Data(const Data& data, const CopyOp& copyop = {}) :
             Object(data, copyop), properties(data.properties) {}
 
-        explicit Data(Properties layout) :
+        explicit Data(const Properties& layout) :
             properties(layout) {}
 
-        Data(Properties layout, uint32_t min_stride) :
+        Data(const Properties& layout, uint32_t min_stride) :
             properties(layout)
         {
             if (properties.stride < min_stride) properties.stride = min_stride;
@@ -240,7 +240,7 @@ namespace vsg
         using Layout = Properties;
 
         /// deprecated: use data->properties = properties instead.
-        void setLayout(Layout layout)
+        void setLayout(const Layout& layout)
         {
             VkFormat previous_format = properties.format; // temporary hack to keep applications that call setFormat(..) before setLayout(..) working
             uint32_t previous_stride = properties.stride;
@@ -251,7 +251,7 @@ namespace vsg
         /// deprecated: use data->properties
         Layout& getLayout() { return properties; }
         /// deprecated: use data->properties
-        Layout getLayout() const { return properties; }
+        const Layout& getLayout() const { return properties; }
 #endif
     };
     VSG_type_name(vsg::Data);
diff --git a/include/vsg/core/Object.h b/include/vsg/core/Object.h
@@ -260,7 +260,7 @@ namespace vsg
 
         C dest;
         dest.reserve(src.size());
-        for (auto& ptr : src)
+        for (const auto& ptr : src)
         {
             dest.push_back(operator()(ptr));
         }

Original file line number	Diff line number	Diff line change
`@@ -57,12 +57,12 @@ namespace vsg`
`57`	`57`	`dirty();`
`58`	`58`	`}`
`59`	`59`
`60`		`- explicit Array(uint32_t numElements, Properties in_properties = {}) :`
	`60`	`+ explicit Array(uint32_t numElements, const Properties& in_properties = {}) :`
`61`	`61`	`Data(in_properties, sizeof(value_type)),`
`62`	`62`	`_data(_allocate(numElements)),`
`63`	`63`	`_size(numElements) { dirty(); }`
`64`	`64`
`65`		`- Array(uint32_t numElements, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
	`65`	`+ Array(uint32_t numElements, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
`66`	`66`	`Data(in_properties, sizeof(value_type)),`
`67`	`67`	`_data(data),`
`68`	`68`	`_size(numElements)`
`@@ -71,7 +71,7 @@ namespace vsg`
`71`	`71`	`dirty();`
`72`	`72`	`}`
`73`	`73`
`74`		`- Array(uint32_t numElements, const value_type& value, Properties in_properties = {}) :`
	`74`	`+ Array(uint32_t numElements, const value_type& value, const Properties& in_properties = {}) :`
`75`	`75`	`Data(in_properties, sizeof(value_type)),`
`76`	`76`	`_data(_allocate(numElements)),`
`77`	`77`	`_size(numElements)`
`@@ -80,7 +80,7 @@ namespace vsg`
`80`	`80`	`dirty();`
`81`	`81`	`}`
`82`	`82`
`83`		`- Array(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t numElements, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
	`83`	`+ Array(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t numElements, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
`84`	`84`	`Data(),`
`85`	`85`	`_data(nullptr),`
`86`	`86`	`_size(0)`
`@@ -247,7 +247,7 @@ namespace vsg`
`247`	`247`	`return *this;`
`248`	`248`	`}`
`249`	`249`
`250`		`- void assign(uint32_t numElements, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
	`250`	`+ void assign(uint32_t numElements, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
`251`	`251`	`{`
`252`	`252`	`_delete();`
`253`	`253`
`@@ -262,7 +262,7 @@ namespace vsg`
`262`	`262`	`dirty();`
`263`	`263`	`}`
`264`	`264`
`265`		`- void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t numElements, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
	`265`	`+ void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t numElements, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
`266`	`266`	`{`
`267`	`267`	`_delete();`
`268`	`268`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ namespace vsg`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`
`60`		`- Array2D(uint32_t width, uint32_t height, Properties in_properties = {}) :`
	`60`	`+ Array2D(uint32_t width, uint32_t height, const Properties& in_properties = {}) :`
`61`	`61`	`Data(in_properties, sizeof(value_type)),`
`62`	`62`	`_data(nullptr),`
`63`	`63`	`_width(width),`
`@@ -67,7 +67,7 @@ namespace vsg`
`67`	`67`	`dirty();`
`68`	`68`	`}`
`69`	`69`
`70`		`- Array2D(uint32_t width, uint32_t height, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
	`70`	`+ Array2D(uint32_t width, uint32_t height, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
`71`	`71`	`Data(in_properties, sizeof(value_type)),`
`72`	`72`	`_data(data),`
`73`	`73`	`_width(width),`
`@@ -77,7 +77,7 @@ namespace vsg`
`77`	`77`	`dirty();`
`78`	`78`	`}`
`79`	`79`
`80`		`- Array2D(uint32_t width, uint32_t height, const value_type& value, Properties in_properties = {}) :`
	`80`	`+ Array2D(uint32_t width, uint32_t height, const value_type& value, const Properties& in_properties = {}) :`
`81`	`81`	`Data(in_properties, sizeof(value_type)),`
`82`	`82`	`_data(nullptr),`
`83`	`83`	`_width(width),`
`@@ -91,7 +91,7 @@ namespace vsg`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`- Array2D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
	`94`	`+ Array2D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
`95`	`95`	`Data(),`
`96`	`96`	`_data(nullptr),`
`97`	`97`	`_width(0),`
`@@ -231,7 +231,7 @@ namespace vsg`
`231`	`231`	`return *this;`
`232`	`232`	`}`
`233`	`233`
`234`		`- void assign(uint32_t width, uint32_t height, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
	`234`	`+ void assign(uint32_t width, uint32_t height, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
`235`	`235`	`{`
`236`	`236`	`_delete();`
`237`	`237`
`@@ -247,7 +247,7 @@ namespace vsg`
`247`	`247`	`dirty();`
`248`	`248`	`}`
`249`	`249`
`250`		`- void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
	`250`	`+ void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
`251`	`251`	`{`
`252`	`252`	`_delete();`
`253`	`253`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ namespace vsg`
`59`	`59`	`}`
`60`	`60`	`}`
`61`	`61`
`62`		`- Array3D(uint32_t width, uint32_t height, uint32_t depth, Properties in_properties = {}) :`
	`62`	`+ Array3D(uint32_t width, uint32_t height, uint32_t depth, const Properties& in_properties = {}) :`
`63`	`63`	`Data(in_properties, sizeof(value_type)),`
`64`	`64`	`_data(nullptr),`
`65`	`65`	`_width(width),`
`@@ -70,7 +70,7 @@ namespace vsg`
`70`	`70`	`dirty();`
`71`	`71`	`}`
`72`	`72`
`73`		`- Array3D(uint32_t width, uint32_t height, uint32_t depth, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
	`73`	`+ Array3D(uint32_t width, uint32_t height, uint32_t depth, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
`74`	`74`	`Data(in_properties, sizeof(value_type)),`
`75`	`75`	`_data(data),`
`76`	`76`	`_width(width),`
`@@ -81,7 +81,7 @@ namespace vsg`
`81`	`81`	`dirty();`
`82`	`82`	`}`
`83`	`83`
`84`		`- Array3D(uint32_t width, uint32_t height, uint32_t depth, const value_type& value, Properties in_properties = {}) :`
	`84`	`+ Array3D(uint32_t width, uint32_t height, uint32_t depth, const value_type& value, const Properties& in_properties = {}) :`
`85`	`85`	`Data(in_properties, sizeof(value_type)),`
`86`	`86`	`_data(nullptr),`
`87`	`87`	`_width(width),`
`@@ -96,7 +96,7 @@ namespace vsg`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
`99`		`- Array3D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
	`99`	`+ Array3D(ref_ptr<Data> data, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr) :`
`100`	`100`	`Data(),`
`101`	`101`	`_data(nullptr),`
`102`	`102`	`_width(0),`
`@@ -242,7 +242,7 @@ namespace vsg`
`242`	`242`	`return *this;`
`243`	`243`	`}`
`244`	`244`
`245`		`- void assign(uint32_t width, uint32_t height, uint32_t depth, value_type* data, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
	`245`	`+ void assign(uint32_t width, uint32_t height, uint32_t depth, value_type* data, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
`246`	`246`	`{`
`247`	`247`	`_delete();`
`248`	`248`
`@@ -259,7 +259,7 @@ namespace vsg`
`259`	`259`	`dirty();`
`260`	`260`	`}`
`261`	`261`
`262`		`- void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, Properties in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
	`262`	`+ void assign(ref_ptr<Data> storage, uint32_t offset, uint32_t stride, uint32_t width, uint32_t height, uint32_t depth, const Properties& in_properties = {}, MipmapLayout* mipmapLayout = nullptr)`
`263`	`263`	`{`
`264`	`264`	`_delete();`
`265`	`265`
Original file line number	Diff line number	Diff line change
`@@ -260,7 +260,7 @@ namespace vsg`
`260`	`260`
`261`	`261`	`C dest;`
`262`	`262`	`dest.reserve(src.size());`
`263`		`- for (auto& ptr : src)`
	`263`	`+ for (const auto& ptr : src)`
`264`	`264`	`{`
`265`	`265`	`dest.push_back(operator()(ptr));`
`266`	`266`	`}`