Add StringSerializer#35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new StringSerializer interface and its implementation for debugging purposes, wires it into the session dependency injection, adds tests for QID and Stat serialization, and removes the Closeable contract from the channel driver.
- Add
StringSerializerinterface andStringSerializerImplclass with methods to serialize QID, Stat, and messages. - Add unit tests for
serializeQidandserializeStat. - Extend
StyxSessionDIandStyxSessionDIImplto provide the newStringSerializer. - Remove
CloseablefromIChannelDriverinterface.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| java/v2soft/styxlib/l5/dev/StringSerializer.java | New interface defining debug serialization methods |
| java/v2soft/styxlib/l5/v9p2000/StringSerializerImpl.java | Implementation of QID, Stat, and message serialization |
| java/v2soft/styxlib/l5/v9p2000/StringSerializerImplTests.java | Unit tests for serializeQid and serializeStat |
| java/v2soft/styxlib/utils/StyxSessionDI.java | DI interface updated to expose StringSerializer |
| java/v2soft/styxlib/utils/StyxSessionDIImpl.java | DI implementation updated to instantiate and return StringSerializerImpl |
| java/v2soft/styxlib/server/IChannelDriver.java | Closeable removed from interface declaration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.