update the connection code to be flexible on the prompt characters#47
Open
RobertBlackhart wants to merge 2 commits intovshymanskyy:mainfrom
Open
update the connection code to be flexible on the prompt characters#47RobertBlackhart wants to merge 2 commits intovshymanskyy:mainfrom
RobertBlackhart wants to merge 2 commits intovshymanskyy:mainfrom
Conversation
|
May I ask why this hasn't been merged? With https://MicroPythonOS.com we also bumped into this issue because we also use aiorepl, and spent time investigating and fixing it, before landing here... Anyway, awesome project, ViperIDE! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
The code will now look for 3 possible prompt values:
>>>standard MicroPython prompt-->aiorepl promptsys.ps1Here's a connection to a board with no customized prompt (same behavior as before the change):
Here's a connection to a board that has the aiorepl demo script in its main.py:
If ViperIDE detects the user has a custom prompt, it will log that fact:
