chore: tweaks

Author: edison1105

packages/runtime-vapor/__tests__/bench/domBinding.bench.ts

@@ -283,17 +283,19 @@ describe('DOM binding effects', () => {
     'setEvent',
     createDiv,
     (el, source) => {
+      const invoker = createInvoker(noop)
       renderEffect(() =>
-        on(el, source.value & 1 ? 'click' : 'mouseover', createInvoker(noop), {
+        on(el, source.value & 1 ? 'click' : 'mouseover', invoker, {
           effect: true,
         }),
       )
     },
     (el, source) => {
+      const invoker = createInvoker(noop)
       setEventBinding(
         el,
         () => (source.value & 1 ? 'click' : 'mouseover'),
-        createInvoker(noop),
+        invoker,
       )
     },
   )

packages/runtime-vapor/__tests__/renderEffect.spec.ts

@@ -442,6 +442,24 @@ describe('renderEffect', () => {
     expect(calls).toEqual(['mouseover'])
   })
 
+  test('setEventBinding does not mutate listener options', () => {
+    const options = { once: true }
+    const button = document.createElement('button')
+    const scope = new EffectScope()
+
+    scope.run(() => {
+      setEventBinding(
+        button,
+        () => 'click',
+        () => {},
+        options,
+      )
+    })
+    scope.stop()
+
+    expect(options).toEqual({ once: true })
+  })
+
   test('should run with the scheduling order', async () => {
     const calls: string[] = []
 

packages/runtime-vapor/src/dom/bindingEffect.ts

@@ -19,6 +19,7 @@ import {
 
 type TextNodeWithCache = Text & { $txt?: string }
 type EventBindingOptions = AddEventListenerOptions & { effect: true }
+const eventBindingOptions: EventBindingOptions = { effect: true }
 type MergedDynamicPropsSource = Record<string, any> | null | undefined
 type DynamicPropsGetter = () => MergedDynamicPropsSource
 
@@ -491,8 +492,9 @@ export function setEventBinding(
   handler: (e: Event) => any | ((e: Event) => any)[],
   options?: AddEventListenerOptions,
 ): void {
-  const effectOptions = (options || {}) as EventBindingOptions
-  effectOptions.effect = true
+  const effectOptions: EventBindingOptions = options
+    ? { ...options, effect: true }
+    : eventBindingOptions
   if (inOnceSlot) {
     on(el, getter(), handler, effectOptions)
     return