Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion packages/server-renderer/__tests__/ssrSuspense.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { Suspense, createApp, h } from 'vue'
import { Suspense, createApp, defineComponent, h } from 'vue'
import { renderToString } from '../src/renderToString'
import { ssrRenderComponent } from '../src/helpers/ssrRenderComponent'
import { ssrRenderSuspense } from '../src/helpers/ssrRenderSuspense'

describe('SSR Suspense', () => {
const ResolvingAsync = {
Expand Down Expand Up @@ -103,6 +105,28 @@ describe('SSR Suspense', () => {
expect('missing template').toHaveBeenWarned()
})

// nuxt/nuxt#28162
test('propagates sync errors from compiled ssrRenderSuspense default slot', async () => {
const Throwing = defineComponent({
ssrRender(_ctx: any, _push: any) {
throw new TypeError('bang')
},
})

const Root = defineComponent({
ssrRender(_ctx: any, _push: any, _parent: any) {
ssrRenderSuspense(_push, {
default: () => {
_push(ssrRenderComponent(Throwing, null, null, _parent))
},
_: 1,
} as any)
},
})

await expect(renderToString(createApp(Root))).rejects.toThrow('bang')
})

test('passing suspense in failing suspense', async () => {
const Comp = {
errorCaptured: vi.fn(() => false),
Expand Down
7 changes: 5 additions & 2 deletions packages/server-renderer/src/helpers/ssrRenderSuspense.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import type { PushFn } from '../render'

export async function ssrRenderSuspense(
// Must remain synchronous: compiled output is `ssrRenderSuspense(_push, ...)`,
// not `_push(ssrRenderSuspense(...))`, so any returned Promise (and its
// rejection) would be silently discarded.
export function ssrRenderSuspense(
push: PushFn,
{ default: renderContent }: Record<string, (() => void) | undefined>,
): Promise<void> {
): void {
if (renderContent) {
renderContent()
} else {
Expand Down
Loading