fix(compiler-sfc): resolve top-level exports from files registered as global types#14805
Open
danielroe wants to merge 1 commit into
Open
fix(compiler-sfc): resolve top-level exports from files registered as global types#14805danielroe wants to merge 1 commit into
danielroe wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR fixes global-scope type caching by introducing a separate cache for global-scope resolutions. Global type files added via ChangesGlobal-Scope Type Cache Separation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts (1)
1769-1776: ⚡ Quick winAssert the priming failure explicitly instead of swallowing it.
At Line 1769, the empty
catch {}can hide regressions where the first compile no longer fails, weakening the test’s intended setup guarantee.Suggested test adjustment
- try { - resolve( - `defineProps<UnknownGlobal>()`, - files, - { globalTypeFiles: ['/globalTypes.d.ts'] }, - '/PrimeGlobal.vue', - ) - } catch {} + expect(() => + resolve( + `defineProps<UnknownGlobal>()`, + files, + { globalTypeFiles: ['/globalTypes.d.ts'] }, + '/PrimeGlobal.vue', + ), + ).toThrow('Unresolvable type reference')🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts` around lines 1769 - 1776, The test currently swallows the expected priming failure by using an empty catch block; instead assert the failure explicitly: call resolve(...) with the same arguments (the `resolve` invocation for "`defineProps<UnknownGlobal>()`" using `globalTypeFiles` and `'/PrimeGlobal.vue'`) inside an assertion that it throws (e.g. use the test framework's expect(...).toThrow or wrap in try/catch and call fail() when no error is thrown) so the test fails if the initial compile unexpectedly succeeds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts`:
- Around line 1769-1776: The test currently swallows the expected priming
failure by using an empty catch block; instead assert the failure explicitly:
call resolve(...) with the same arguments (the `resolve` invocation for
"`defineProps<UnknownGlobal>()`" using `globalTypeFiles` and
`'/PrimeGlobal.vue'`) inside an assertion that it throws (e.g. use the test
framework's expect(...).toThrow or wrap in try/catch and call fail() when no
error is thrown) so the test fails if the initial compile unexpectedly succeeds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 30da15ee-fec1-4cab-b035-303d98725518
📒 Files selected for processing (2)
packages/compiler-sfc/__tests__/compileScript/resolveType.spec.tspackages/compiler-sfc/src/script/resolveType.ts
Member
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves nuxt/nuxt#33694
the issue is that files registered as
globalTypeFilesthat contain plain top-levelexportdeclarations (nodeclare global { ... }) were cached with an empty TypeScope and that cached scope was then reused for regularimport { Foo } from '...'resolution, so imports of those types failed to resolve.Summary by CodeRabbit
Tests
Refactor