fix(runtime-vapor): animate vapor component moves in TransitionGroup#14866
fix(runtime-vapor): animate vapor component moves in TransitionGroup#14866edison1105 wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
a717010 to
ec06ebb
Compare
ec06ebb to
b527cc4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages-private/vapor-e2e-test/__tests__/transition-group.spec.ts`:
- Around line 1238-1245: The test shows the interop keyed-VDOM path isn't
applying the move class so ensure the interop transition-group code reproduces
the same keyed-move contract as native VDOM: when keyed items are reordered, add
the "group-move" class to the moved DOM node (e.g., the element with id
"item-2") using the same move-detection and class-application logic as the
non-interop path; locate the transition-group/interop keyed-reconcile code that
handles keyed swaps and reuse or call the existing add-move-class routine so the
expectation in the test using containerSelector (checking for "group-move") is
satisfied.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 45d85c5c-4f9e-4549-abcd-6ae077138146
📒 Files selected for processing (17)
packages-private/vapor-e2e-test/__tests__/transition-group.spec.tspackages-private/vapor-e2e-test/__tests__/vdomInterop.spec.tspackages-private/vapor-e2e-test/interop/App.vuepackages-private/vapor-e2e-test/interop/components/VdomTransitionGroup.vuepackages-private/vapor-e2e-test/transition-group/cases/interop/keyed-vdom-component-move-after-key-change.vuepackages-private/vapor-e2e-test/transition-group/cases/vapor-transition-group/async-root-slot-component-move.vuepackages-private/vapor-e2e-test/transition-group/cases/vapor-transition-group/keyed-component-move-after-key-change.vuepackages-private/vapor-e2e-test/transition-group/cases/vapor-transition-group/root-slot-component-move.vuepackages-private/vapor-e2e-test/transition-group/components/RootSlot.vuepackages-private/vapor-e2e-test/transition-group/components/VaporExpandingItem.vuepackages-private/vapor-e2e-test/transition-group/components/VdomExpandingItem.vuepackages/runtime-vapor/__tests__/for.spec.tspackages/runtime-vapor/src/apiCreateFor.tspackages/runtime-vapor/src/components/Transition.tspackages/runtime-vapor/src/components/TransitionGroup.tspackages/runtime-vapor/src/fragment.tspackages/runtime-vapor/src/vdomInterop.ts
✅ Files skipped from review due to trivial changes (3)
- packages-private/vapor-e2e-test/transition-group/components/VaporExpandingItem.vue
- packages/runtime-vapor/src/fragment.ts
- packages-private/vapor-e2e-test/transition-group/components/RootSlot.vue
b527cc4 to
a5db91d
Compare
close #14862
Summary by CodeRabbit
Tests
New Features