Skip to content

fix(Portal): apply position:relative so z-index creates a stacking context #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sridhar-3009 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Portal): apply position:relative so z-index creates a stacking context #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/0/src/components/Portal/Portal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,14 @@
}

export interface PortalSlotProps {
/** Calculated z-index from useStack */
/**
* Calculated z-index from useStack.
*
* @remarks
* Must be applied to a **positioned** element (`position: relative`, `absolute`,
* `fixed`, or `sticky`) to create a stacking context. Applying it to a
* `position: static` element has no effect.
*/
zIndex: number
/** Close this portal (unselects from stack) */
close: () => void
Expand Down
4 changes: 2 additions & 2 deletions packages/0/src/components/Snackbar/SnackbarPortal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
zIndex: number
/** Attributes to bind to the portal element */
attrs: {
style: { zIndex: number }
style: { position: 'relative', zIndex: number }
}
}
</script>
Expand All @@ -57,7 +57,7 @@
return {
zIndex,
attrs: {
style: { zIndex },
style: { position: 'relative' as const, zIndex },
},
}
}
Expand Down
Loading