Skip to content

Commit 5e6c790

Browse files
committed
chore(VPagination): use data-testid instead of data-test
1 parent c8a245c commit 5e6c790

2 files changed

Lines changed: 10 additions & 14 deletions

File tree

packages/vuetify/src/components/VPagination/VPagination.tsx

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -339,18 +339,18 @@ export const VPagination = genericComponent<VPaginationSlots>()({
339339
role="navigation"
340340
aria-label={ t(props.ariaLabel) }
341341
onKeydown={ onKeydown }
342-
data-test="v-pagination-root"
342+
data-testid="v-pagination-root"
343343
>
344344
<ul class="v-pagination__list">
345345
{[true, 'only-first'].includes(props.showFirstLastPage) && (
346-
<li key="first" class="v-pagination__first" data-test="v-pagination-first">
346+
<li key="first" class="v-pagination__first" data-testid="v-pagination-first">
347347
{ slots.first ? slots.first(controls.value.first!) : (
348348
<VBtn _as="VPaginationBtn" { ...controls.value.first } />
349349
)}
350350
</li>
351351
)}
352352

353-
<li key="prev" class="v-pagination__prev" data-test="v-pagination-prev">
353+
<li key="prev" class="v-pagination__prev" data-testid="v-pagination-prev">
354354
{ slots.prev ? slots.prev(controls.value.prev) : (
355355
<VBtn _as="VPaginationBtn" { ...controls.value.prev } />
356356
)}
@@ -365,26 +365,22 @@ export const VPagination = genericComponent<VPaginationSlots>()({
365365
'v-pagination__item--is-active': item.isActive,
366366
},
367367
]}
368-
data-test="v-pagination-item"
368+
data-testid="v-pagination-item"
369369
>
370370
{ slots.item ? slots.item(item) : (
371371
<VBtn _as="VPaginationBtn" { ...item.props }>{ item.page }</VBtn>
372372
)}
373373
</li>
374374
))}
375375

376-
<li
377-
key="next"
378-
class="v-pagination__next"
379-
data-test="v-pagination-next"
380-
>
376+
<li key="next" class="v-pagination__next" data-testid="v-pagination-next">
381377
{ slots.next ? slots.next(controls.value.next) : (
382378
<VBtn _as="VPaginationBtn" { ...controls.value.next } />
383379
)}
384380
</li>
385381

386382
{ props.showFirstLastPage === true && (
387-
<li key="last" class="v-pagination__last" data-test="v-pagination-last">
383+
<li key="last" class="v-pagination__last" data-testid="v-pagination-last">
388384
{ slots.last ? slots.last(controls.value.last!) : (
389385
<VBtn _as="VPaginationBtn" { ...controls.value.last } />
390386
)}

packages/vuetify/src/components/VPagination/__tests__/VPagination.spec.browser.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,17 @@ describe('VPagination', () => {
2828
<VPagination showFirstLastPage={ false } length="3" />
2929
))
3030

31-
expect(screen.queryByCSS('[data-test="v-pagination-first"]')).not.toBeInTheDocument()
32-
expect(screen.queryByCSS('[data-test="v-pagination-last"]')).not.toBeInTheDocument()
31+
expect(screen.queryByTestId('v-pagination-first')).not.toBeInTheDocument()
32+
expect(screen.queryByTestId('v-pagination-last')).not.toBeInTheDocument()
3333
})
3434

3535
it('should render without last page button', () => {
3636
render(() => (
3737
<VPagination showFirstLastPage="only-first" showlength="3" />
3838
))
3939

40-
expect(screen.queryByCSS('[data-test="v-pagination-first"]')).toBeInTheDocument()
41-
expect(screen.queryByCSS('[data-test="v-pagination-last"]')).not.toBeInTheDocument()
40+
expect(screen.queryByTestId('v-pagination-first')).toBeInTheDocument()
41+
expect(screen.queryByTestId('v-pagination-last')).not.toBeInTheDocument()
4242
})
4343

4444
it('should react to mouse navigation', async () => {

0 commit comments

Comments
 (0)