feat(VTimePicker): Add keyboard controls#22604
Conversation
|
The immediate problem becomes - assistive tools will show the clock has 12 options for minutes and seconds with gaps. Not sure if VBtn approach is correct here. Maybe the clock should have role |
6d568d8 to
667b82d
Compare
|
The claim "because tests look ugly" is too weak to justify the risk unintentional styling accidents. E.g. user can make all VBtn have strong shadow and even supplement custom CSS, just to later realize it leaks into this component. Everything else looks good and we could merge without VBtn. |
5b257fd to
86800d9
Compare
@J-Sek Looks like all the v-btn issues you are explaining are not relevant anymore because this VBtn now has Let me know if I'm wrong |
|
@ikushum, thanks for the answer. I think I had CSS and Sass variables in mind - e.g. solid "brutalist" shadow is easier to pull off with custom CSS. And I did not notice we have added Also, when both parts are visible (inputs and the clock), the interaction feels a bit weird... I mean, the user [Tab]s over to reach the clock, but can only change the last segment (minutes or seconds). Theoretically we could re-assign left/right arrows to toggle hours/minutes/seconds. Sorry for not bringing it in the very first feedback batch. Fixed it in last commit. |
fixes #10722, #21885
Description
Markup: