Skip to content

fix(VAutocomplete/VCombobox): click in empty space should not close menu #22754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
J-Sek wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(VAutocomplete/VCombobox): click in empty space should not close menu #22754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/vuetify/src/components/VAutocomplete/VAutocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,9 @@ export const VAutocomplete = genericComponent<new <
}

function onBlur (e: FocusEvent) {
const menuContent = vMenuRef.value?.contentEl
if (menuContent?.contains(e.relatedTarget as Node)) {
isFocused.value = true
const target = e.target as Element
if (!vTextFieldRef.value?.$el.contains(target)) {
menu.value = false
}
}

Expand Down Expand Up @@ -417,7 +417,6 @@ export const VAutocomplete = genericComponent<new <
nextTick(() => isSelecting.value = false)
} else {
if (!props.multiple && search.value == null) model.value = []
menu.value = false
if (!isPristine.value && search.value) {
_searchLock.value = search.value
}
Expand Down Expand Up @@ -538,7 +537,6 @@ export const VAutocomplete = genericComponent<new <
filterable
selected={ selectedValues.value }
selectStrategy={ props.multiple ? 'independent' : 'single-independent' }
onMousedown={ (e: MouseEvent) => e.preventDefault() }
onFocusout={ onFocusout }
tabindex="-1"
selectable={ !!displayItems.value.length }
Expand Down
8 changes: 3 additions & 5 deletions packages/vuetify/src/components/VCombobox/VCombobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,17 +469,16 @@ export const VCombobox = genericComponent<new <
}

function onBlur (e: FocusEvent) {
const menuContent = vMenuRef.value?.contentEl
if (menuContent?.contains(e.relatedTarget as Node)) {
isFocused.value = true
const target = e.target as Element
if (!vTextFieldRef.value?.$el.contains(target)) {
menu.value = false
}
}

watch(isFocused, (val, oldVal) => {
if (val || val === oldVal) return

selectionIndex.value = -1
menu.value = false

if (search.value) {
if (props.multiple) {
Expand Down Expand Up @@ -601,7 +600,6 @@ export const VCombobox = genericComponent<new <
filterable
selected={ selectedValues.value }
selectStrategy={ props.multiple ? 'independent' : 'single-independent' }
onMousedown={ (e: MouseEvent) => e.preventDefault() }
selectable={ !!displayItems.value.length }
onFocusout={ onFocusout }
tabindex="-1"
Expand Down
Loading