removed sinon.createSandbox from nested beforeEach blocks in test.compute.ts, test.jwt.ts, and test.impersonated.ts.

Author: vverman

core/packages/google-auth-library-nodejs/src/auth/regionalaccessboundary.ts

@@ -63,7 +63,6 @@ export interface RegionalAccessBoundaryData {
   encodedLocations: string;
 }
 
-
 export interface RegionalAccessBoundaryManagerOptions {
   transporter: Gaxios;
   getLookupUrl: () => Promise<string | null>;
@@ -82,7 +81,6 @@ export class RegionalAccessBoundaryManager {
     this.options = options;
   }
 
-
   /**
    * @internal
    */

core/packages/google-auth-library-nodejs/test/test.compute.ts

@@ -269,8 +269,6 @@ describe('compute', () => {
     assert.fail('failed to throw');
   });
   describe('regional access boundaries', () => {
-    let sandbox: sinon.SinonSandbox;
-
     const MOCK_ACCESS_TOKEN = 'abc123';
     const MOCK_AUTH_HEADER = `Bearer ${MOCK_ACCESS_TOKEN}`;
     const EXPECTED_RAB_DATA: RegionalAccessBoundaryData = {
@@ -307,14 +305,12 @@ describe('compute', () => {
     }
 
     beforeEach(() => {
-      sandbox = sinon.createSandbox();
       (
         Compute.prototype.getRegionalAccessBoundaryUrl as sinon.SinonStub
       ).restore();
     });
 
     afterEach(() => {
-      sandbox.restore();
       nock.cleanAll();
     });
 

core/packages/google-auth-library-nodejs/test/test.impersonated.ts

@@ -603,7 +603,6 @@ describe('impersonated', () => {
   });
 
   describe('regional access boundaries', () => {
-    let sandbox: sinon.SinonSandbox;
     const TARGET_PRINCIPAL_EMAIL = 'target@project.iam.gserviceaccount.com';
     const MOCK_ACCESS_TOKEN = 'abc123';
     const MOCK_AUTH_HEADER = `Bearer ${MOCK_ACCESS_TOKEN}`;
@@ -628,14 +627,12 @@ describe('impersonated', () => {
     }
 
     beforeEach(() => {
-      sandbox = sinon.createSandbox();
       (
         Impersonated.prototype.getRegionalAccessBoundaryUrl as sinon.SinonStub
       ).restore();
     });
 
     afterEach(() => {
-      sandbox.restore();
       nock.cleanAll();
     });
 

core/packages/google-auth-library-nodejs/test/test.jwt.ts

@@ -1253,7 +1253,6 @@ describe('jwt', () => {
   });
 
   describe('regional access boundaries', () => {
-    let sandbox: sinon.SinonSandbox;
     const SERVICE_ACCOUNT_EMAIL = 'service-account@example.com';
     const MOCK_ACCESS_TOKEN = 'abc123';
     const MOCK_AUTH_HEADER = `Bearer ${MOCK_ACCESS_TOKEN}`;
@@ -1279,12 +1278,10 @@ describe('jwt', () => {
     }
 
     beforeEach(() => {
-      sandbox = sinon.createSandbox();
       (JWT.prototype.getRegionalAccessBoundaryUrl as sinon.SinonStub).restore();
     });
 
     afterEach(() => {
-      sandbox.restore();
       nock.cleanAll();
     });