Fix registry.js import#89
Merged
Merged
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry.js doesn't actually have a default import.
Its output is CJS (this is effectively what's being imported) and exports an explicit list of fields with no
defaultset.Node.js will emulate a fake default export in this case to make this work regardless, but some other environments (most notably ts-node & tsx) won't do that, which makes this fail. To repro:
Clone this repo,
npm install tsx, then:Really this should fail - the equivalent ESM code for this module would really be a set of named exports, with no default export. This PR fixes that so this can be used with tsx/ts-node, and makes the import conceptually more correct by pulling the module namespace that's actually being exported.