Skip to content

Commit 8ae4999

Browse files
committed
docs: update branching strategy from rebase to merge
1 parent 13c1803 commit 8ae4999

3 files changed

Lines changed: 24 additions & 28 deletions

File tree

CODE_OF_CONDUCT.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55
This is a fork of the original [github.com/tmc/langchaingo](https://github.com/tmc/langchaingo) repository. This fork follows a specific branching strategy:
66

7-
- **main**: Fully synchronized with upstream (`tmc/langchaingo`). Never force-pushed.
8-
- **main-pull-requests**: Contains merged PRs from upstream that haven't been officially merged. Rebased on `main`.
9-
- **main-vxcontrol**: Default branch containing all current enhancements. Rebased on `main-pull-requests`.
10-
- **release/v***: Created from `main-vxcontrol` for each release. These branches are stable and never force-pushed.
7+
- **main**: Fully synchronized with upstream (`tmc/langchaingo`) using fast-forward merges.
8+
- **main-pull-requests**: Contains useful PRs from upstream that haven't been officially merged. Updated by merging from `main` after synchronization.
9+
- **main-vxcontrol**: Default branch containing all current enhancements including module name changes and stability improvements. Updated by merging from `main-pull-requests`.
10+
- **release/v***: Created from `main-vxcontrol` for each release. These branches are stable to use in production, all tags are linked to these branches.
1111

1212
For more information about this fork's structure and purpose, please refer to our [README](README.md).
1313

CONTRIBUTING.md

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ This is a fork of the original [github.com/tmc/langchaingo](https://github.com/t
1212

1313
This repository follows a specific branching strategy:
1414

15-
- **main**: Fully synchronized with upstream (`tmc/langchaingo`). Never force-pushed.
16-
- **main-pull-requests**: Contains merged PRs from upstream that haven't been officially merged. Rebased on `main` after synchronization (commit hashes will change).
17-
- **main-vxcontrol**: Default branch containing all current enhancements. Rebased on `main-pull-requests` (commit hashes will change).
18-
- **release/v***: Created from `main-vxcontrol` for each release. These branches are stable and never force-pushed.
15+
- **main**: Fully synchronized with upstream (`tmc/langchaingo`) using fast-forward merges.
16+
- **main-pull-requests**: Contains useful PRs from upstream that haven't been officially merged. Updated by merging from `main` after synchronization.
17+
- **main-vxcontrol**: Default branch containing all current enhancements including module name changes and stability improvements. Updated by merging from `main-pull-requests`.
18+
- **release/v***: Created from `main-vxcontrol` for each release. These branches are stable to use in production, all tags are linked to these branches.
1919

2020
Release tags follow the format `v0.1.13-update.1`, where:
2121
- `v0.1.13` corresponds to the latest upstream release version
@@ -182,7 +182,7 @@ Click **Make a contribution** at the bottom of any docs page to make small chang
182182

183183
3. Create a working branch from the `main-vxcontrol` branch and start with your changes!
184184

185-
**Important**: Note that the `main-vxcontrol` branch undergoes rebasing as we sync with upstream, so its commit hashes will change over time. Always create Pull Requests based on the current state of the `main-vxcontrol` branch.
185+
**Important**: Always create Pull Requests based on the current state of the `main-vxcontrol` branch.
186186

187187
##### Recent Updates and Dependencies
188188

@@ -498,14 +498,10 @@ Commit the changes once you are happy with them. Don't forget to self-review to
498498
#### Pull Request
499499

500500
When you're finished with the changes, create a pull request, also known as a PR.
501-
<<<<<<< HEAD
501+
- Base your PR against the `main-vxcontrol` branch, not the `main` branch.
502502
- Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to [Go Contribute Guideline](https://go.dev/doc/contribute#commit_messages). (such as `memory: add interfaces` or `util: add helpers`)
503503
- Run all linters and ensure tests pass: `make lint && make test`
504504
- If you added new HTTP-based functionality, include httprr recordings
505-
=======
506-
- Base your PR against the `main-vxcontrol` branch, not the `main` branch.
507-
- Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to [Go Contribute Guideline](https://go.dev/doc/contribute#commit_messages). (such as `memory: added interfaces` or `util: added helpers`)
508-
>>>>>>> d174a61d (docs: update CODE_OF_CONDUCT and CONTRIBUTING with fork information and branching strategy)
509505
- **We strive to conceptually align with the Python and TypeScript versions of Langchain. Please link/reference the associated concepts in those codebases when introducing a new concept.**
510506
- Fill the "Ready for review" template so that we can review your PR. This template helps reviewers understand your changes as well as the purpose of your pull request.
511507
- Don't forget to [link PR to issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) if you are solving one.
@@ -519,6 +515,6 @@ Once you submit your PR, a team member will review your proposal. We may ask que
519515

520516
Congratulations :tada::tada: The langchaingo team thanks you :sparkles:.
521517

522-
Once your PR is merged, your contributions will be included in the next release when enough changes have accumulated. Your changes will be included in the next stable release with fixed commit hashes.
518+
Once your PR is merged, your contributions will be included in the next release when enough changes have accumulated.
523519

524520
Now that you are part of the community!

README.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ This repository follows a specific branching strategy to maintain both upstream
3232
3333
### Branch Management
3434
35-
- **main**: Fully synchronized with upstream (`tmc/langchaingo`). Never force-pushed.
36-
- **main-pull-requests**: Contains merged PRs from upstream that haven't been officially merged. Rebased on `main` after synchronization (commit hashes will change).
37-
- **main-vxcontrol**: Default branch containing all current enhancements. Rebased on `main-pull-requests` (commit hashes will change).
38-
- **release/v***: Created from `main-vxcontrol` for each release. These branches are stable and never force-pushed.
35+
- **main**: Fully synchronized with upstream (`tmc/langchaingo`) using fast-forward merges.
36+
- **main-pull-requests**: Contains useful PRs from upstream that haven't been officially merged. Updated by merging from `main` after synchronization.
37+
- **main-vxcontrol**: Default branch containing all current enhancements including module name changes and stability improvements. Updated by merging from `main-pull-requests`.
38+
- **release/v***: Created from `main-vxcontrol` for each release. These branches are stable to use in production, all tags are linked to these branches.
3939
4040
### Versioning
4141
@@ -47,7 +47,7 @@ Each new release cumulatively includes all changes from previous releases on top
4747
4848
### Dependency Management
4949
50-
**Important**: When using this fork in your projects, always reference **release tags** rather than commit hashes. This ensures proper dependency resolution since branches like `main-vxcontrol` undergo rebasing and their commit hashes change over time.
50+
**Important**: When using this fork in your projects, always reference **release tags** for stable and predictable dependencies.
5151
5252
```
5353
go get github.com/vxcontrol/langchaingo@v0.1.13-update.1
@@ -57,19 +57,19 @@ go get github.com/vxcontrol/langchaingo@v0.1.13-update.1
5757
5858
```
5959
main A---B---C---D---E---F (synced with upstream)
60-
\
61-
main-pull-requests \---G---H---I (rebased on main, PRs from upstream)
62-
\
63-
main-vxcontrol \---J---K---L (default branch, rebased on main-pull-requests)
64-
\
65-
release/vM.M.P-update.N M (tagged stable release)
60+
\ \
61+
main-pull-requests G---H---I---J (merged from main, PRs from upstream)
62+
\ \
63+
main-vxcontrol K---L---M (default branch, merged from main-pull-requests)
64+
\
65+
release/vM.M.P-update.N N (tagged stable release)
6666
```
6767
6868
### For Contributors
6969
70-
If you want to contribute to this fork, please create Pull Requests based on the current state of the `main-vxcontrol` branch. Even though commit hashes in this branch may change due to rebasing, your contributions will be included in the next release when enough changes have accumulated.
70+
If you want to contribute to this fork, please create Pull Requests based on the current state of the `main-vxcontrol` branch. Your contributions will be included in the next release when enough changes have accumulated.
7171
72-
When creating a PR, please ensure your changes are well-tested and include appropriate documentation. Once merged, your contributions will be included in the next stable release with fixed commit hashes.
72+
When creating a PR, please ensure your changes are well-tested and include appropriate documentation. Once merged, your contributions will be included in the next stable release.
7373
7474
## Acknowledgements
7575

0 commit comments

Comments
 (0)