feature-296-bugbot-autofix: Implement truncation for finding body comments exceeding 12000 characters to prevent prompt bloat, and update related tests to ensure functionality; also limit verify commands to 20 with appropriate logging.

efraespada · efraespada · commit 95033db8753f · 2026-02-12T02:56:45.000+01:00
diff --git a/build/cli/index.js b/build/cli/index.js
@@ -54111,6 +54111,8 @@ const exec = __importStar(__nccwpck_require__(1514));
 const shellQuote = __importStar(__nccwpck_require__(7029));
 const project_repository_1 = __nccwpck_require__(7917);
 const logger_1 = __nccwpck_require__(8836);
+/** Maximum number of verify commands to run to avoid excessive build times. */
+const MAX_VERIFY_COMMANDS = 20;
 /**
  * Returns true if there are uncommitted changes (working tree or index).
  */
@@ -54240,6 +54242,10 @@ async function runBugbotAutofixCommitAndPush(execution, options) {
         verifyCommands = [];
     }
     verifyCommands = verifyCommands.filter((cmd) => typeof cmd === "string");
+    if (verifyCommands.length > MAX_VERIFY_COMMANDS) {
+        (0, logger_1.logInfo)(`Limiting verify commands to ${MAX_VERIFY_COMMANDS} (configured: ${verifyCommands.length}).`);
+        verifyCommands = verifyCommands.slice(0, MAX_VERIFY_COMMANDS);
+    }
     if (verifyCommands.length > 0) {
         (0, logger_1.logInfo)(`Running ${verifyCommands.length} verify command(s)...`);
         const verify = await runVerifyCommands(verifyCommands);
@@ -54342,7 +54348,7 @@ class BugbotAutofixUseCase {
             success: true,
             executed: true,
             steps: [
-                `Bugbot autofix completed. OpenCode applied changes for findings: ${idsToFix.join(", ")}. Run verify commands and commit/push.`,
+            // `Bugbot autofix completed. OpenCode applied changes for findings: ${idsToFix.join(", ")}. Run verify commands and commit/push.`,
             ],
             payload: { targetFindingIds: idsToFix, context },
         }));
@@ -54444,6 +54450,17 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.buildBugbotFixPrompt = buildBugbotFixPrompt;
 const opencode_project_context_instruction_1 = __nccwpck_require__(7381);
 const sanitize_user_comment_for_prompt_1 = __nccwpck_require__(3514);
+/** Maximum characters for a single finding's full comment body to avoid prompt bloat and token limits. */
+const MAX_FINDING_BODY_LENGTH = 12000;
+const TRUNCATION_SUFFIX = "\n\n[... truncated for length ...]";
+/**
+ * Truncates body to max length and appends indicator when truncated.
+ */
+function truncateFindingBody(body, maxLength) {
+    if (body.length <= maxLength)
+        return body;
+    return body.slice(0, maxLength - TRUNCATION_SUFFIX.length) + TRUNCATION_SUFFIX;
+}
 /**
  * Builds the prompt for the OpenCode build agent to fix the selected bugbot findings.
  * Includes repo context, the findings to fix (with full detail), the user's comment,
@@ -54463,7 +54480,7 @@ function buildBugbotFixPrompt(param, context, targetFindingIds, userComment, ver
         if (!data)
             return null;
         const issueBody = context.issueComments.find((c) => c.id === data.issueCommentId)?.body ?? null;
-        const fullBody = issueBody?.trim() ?? "";
+        const fullBody = truncateFindingBody((issueBody?.trim() ?? ""), MAX_FINDING_BODY_LENGTH);
         if (!fullBody)
             return null;
         return `---\n**Finding id:** \`${id}\`\n\n**Full comment (title, description, location, suggestion):**\n${fullBody}\n`;
@@ -54692,7 +54709,7 @@ class DetectBugbotFixIntentUseCase {
             success: true,
             executed: true,
             steps: [
-                `Bugbot fix intent: isFixRequest=${isFixRequest}, targetFindingIds=${filteredIds.length} (${filteredIds.join(", ") || "none"}).`,
+            // `Bugbot fix intent: isFixRequest=${isFixRequest}, targetFindingIds=${filteredIds.length} (${filteredIds.join(", ") || "none"}).`,
             ],
             payload: {
                 isFixRequest,
diff --git a/build/github_action/index.js b/build/github_action/index.js
@@ -49200,6 +49200,8 @@ const exec = __importStar(__nccwpck_require__(1514));
 const shellQuote = __importStar(__nccwpck_require__(7029));
 const project_repository_1 = __nccwpck_require__(7917);
 const logger_1 = __nccwpck_require__(8836);
+/** Maximum number of verify commands to run to avoid excessive build times. */
+const MAX_VERIFY_COMMANDS = 20;
 /**
  * Returns true if there are uncommitted changes (working tree or index).
  */
@@ -49329,6 +49331,10 @@ async function runBugbotAutofixCommitAndPush(execution, options) {
         verifyCommands = [];
     }
     verifyCommands = verifyCommands.filter((cmd) => typeof cmd === "string");
+    if (verifyCommands.length > MAX_VERIFY_COMMANDS) {
+        (0, logger_1.logInfo)(`Limiting verify commands to ${MAX_VERIFY_COMMANDS} (configured: ${verifyCommands.length}).`);
+        verifyCommands = verifyCommands.slice(0, MAX_VERIFY_COMMANDS);
+    }
     if (verifyCommands.length > 0) {
         (0, logger_1.logInfo)(`Running ${verifyCommands.length} verify command(s)...`);
         const verify = await runVerifyCommands(verifyCommands);
@@ -49431,7 +49437,7 @@ class BugbotAutofixUseCase {
             success: true,
             executed: true,
             steps: [
-                `Bugbot autofix completed. OpenCode applied changes for findings: ${idsToFix.join(", ")}. Run verify commands and commit/push.`,
+            // `Bugbot autofix completed. OpenCode applied changes for findings: ${idsToFix.join(", ")}. Run verify commands and commit/push.`,
             ],
             payload: { targetFindingIds: idsToFix, context },
         }));
@@ -49533,6 +49539,17 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.buildBugbotFixPrompt = buildBugbotFixPrompt;
 const opencode_project_context_instruction_1 = __nccwpck_require__(7381);
 const sanitize_user_comment_for_prompt_1 = __nccwpck_require__(3514);
+/** Maximum characters for a single finding's full comment body to avoid prompt bloat and token limits. */
+const MAX_FINDING_BODY_LENGTH = 12000;
+const TRUNCATION_SUFFIX = "\n\n[... truncated for length ...]";
+/**
+ * Truncates body to max length and appends indicator when truncated.
+ */
+function truncateFindingBody(body, maxLength) {
+    if (body.length <= maxLength)
+        return body;
+    return body.slice(0, maxLength - TRUNCATION_SUFFIX.length) + TRUNCATION_SUFFIX;
+}
 /**
  * Builds the prompt for the OpenCode build agent to fix the selected bugbot findings.
  * Includes repo context, the findings to fix (with full detail), the user's comment,
@@ -49552,7 +49569,7 @@ function buildBugbotFixPrompt(param, context, targetFindingIds, userComment, ver
         if (!data)
             return null;
         const issueBody = context.issueComments.find((c) => c.id === data.issueCommentId)?.body ?? null;
-        const fullBody = issueBody?.trim() ?? "";
+        const fullBody = truncateFindingBody((issueBody?.trim() ?? ""), MAX_FINDING_BODY_LENGTH);
         if (!fullBody)
             return null;
         return `---\n**Finding id:** \`${id}\`\n\n**Full comment (title, description, location, suggestion):**\n${fullBody}\n`;
@@ -49781,7 +49798,7 @@ class DetectBugbotFixIntentUseCase {
             success: true,
             executed: true,
             steps: [
-                `Bugbot fix intent: isFixRequest=${isFixRequest}, targetFindingIds=${filteredIds.length} (${filteredIds.join(", ") || "none"}).`,
+            // `Bugbot fix intent: isFixRequest=${isFixRequest}, targetFindingIds=${filteredIds.length} (${filteredIds.join(", ") || "none"}).`,
             ],
             payload: {
                 isFixRequest,
diff --git a/src/usecase/steps/commit/bugbot/__tests__/build_bugbot_fix_prompt.test.ts b/src/usecase/steps/commit/bugbot/__tests__/build_bugbot_fix_prompt.test.ts
@@ -73,4 +73,23 @@ describe("buildBugbotFixPrompt", () => {
         const prompt = buildBugbotFixPrompt(mockExecution(), mockContext(), ["find-1"], "fix", []);
         expect(prompt).toContain("Run any standard project checks");
     });
+
+    it("truncates finding body when it exceeds 12000 characters and appends truncation indicator", () => {
+        const longBody = "x".repeat(15000);
+        const context = mockContext({
+            issueComments: [{ id: 1, body: longBody }],
+        });
+        const prompt = buildBugbotFixPrompt(
+            mockExecution(),
+            context,
+            ["find-1"],
+            "fix",
+            []
+        );
+        expect(prompt).toContain("find-1");
+        expect(prompt).toContain("[... truncated for length ...]");
+        const xCount = (prompt.match(/x/g) ?? []).length;
+        expect(xCount).toBeLessThan(15000);
+        expect(xCount).toBeLessThanOrEqual(12000);
+    });
 });
diff --git a/src/usecase/steps/commit/bugbot/bugbot_autofix_use_case.ts b/src/usecase/steps/commit/bugbot/bugbot_autofix_use_case.ts
@@ -84,7 +84,7 @@ export class BugbotAutofixUseCase implements ParamUseCase<BugbotAutofixParam, Re
                 success: true,
                 executed: true,
                 steps: [
-                    `Bugbot autofix completed. OpenCode applied changes for findings: ${idsToFix.join(", ")}. Run verify commands and commit/push.`,
+                    // `Bugbot autofix completed. OpenCode applied changes for findings: ${idsToFix.join(", ")}. Run verify commands and commit/push.`,
                 ],
                 payload: { targetFindingIds: idsToFix, context },
             })
diff --git a/src/usecase/steps/commit/bugbot/build_bugbot_fix_prompt.ts b/src/usecase/steps/commit/bugbot/build_bugbot_fix_prompt.ts
@@ -3,6 +3,19 @@ import type { BugbotContext } from "./types";
 import { OPENCODE_PROJECT_CONTEXT_INSTRUCTION } from "../../../../utils/opencode_project_context_instruction";
 import { sanitizeUserCommentForPrompt } from "./sanitize_user_comment_for_prompt";
 
+/** Maximum characters for a single finding's full comment body to avoid prompt bloat and token limits. */
+const MAX_FINDING_BODY_LENGTH = 12000;
+
+const TRUNCATION_SUFFIX = "\n\n[... truncated for length ...]";
+
+/**
+ * Truncates body to max length and appends indicator when truncated.
+ */
+function truncateFindingBody(body: string, maxLength: number): string {
+    if (body.length <= maxLength) return body;
+    return body.slice(0, maxLength - TRUNCATION_SUFFIX.length) + TRUNCATION_SUFFIX;
+}
+
 /**
  * Builds the prompt for the OpenCode build agent to fix the selected bugbot findings.
  * Includes repo context, the findings to fix (with full detail), the user's comment,
@@ -28,7 +41,7 @@ export function buildBugbotFixPrompt(
             const data = context.existingByFindingId[id];
             if (!data) return null;
             const issueBody = context.issueComments.find((c) => c.id === data.issueCommentId)?.body ?? null;
-            const fullBody = issueBody?.trim() ?? "";
+            const fullBody = truncateFindingBody((issueBody?.trim() ?? ""), MAX_FINDING_BODY_LENGTH);
             if (!fullBody) return null;
             return `---\n**Finding id:** \`${id}\`\n\n**Full comment (title, description, location, suggestion):**\n${fullBody}\n`;
         })
diff --git a/src/usecase/steps/commit/bugbot/detect_bugbot_fix_intent_use_case.ts b/src/usecase/steps/commit/bugbot/detect_bugbot_fix_intent_use_case.ts
@@ -144,7 +144,7 @@ export class DetectBugbotFixIntentUseCase implements ParamUseCase<Execution, Res
                 success: true,
                 executed: true,
                 steps: [
-                    `Bugbot fix intent: isFixRequest=${isFixRequest}, targetFindingIds=${filteredIds.length} (${filteredIds.join(", ") || "none"}).`,
+                    // `Bugbot fix intent: isFixRequest=${isFixRequest}, targetFindingIds=${filteredIds.length} (${filteredIds.join(", ") || "none"}).`,
                 ],
                 payload: {
                     isFixRequest,
