simplify via connection guard

Author: vytskalt

implementation/src/main/java/net/megavex/scoreboardlibrary/implementation/packetAdapter/modern/team/LegacyTeamDisplayPacketAdapter.java

@@ -142,23 +142,12 @@ public void sendProperties(@NotNull PropertiesPacketType packetType, @NotNull Co
 
   private static void sendRawPacket(ViaAPI<Player> via, Player player, UserConnection connection, ByteBuf packet) {
     final Channel channel = connection.getChannel();
-    if (!ViaConnectionGuard.isCurrentPlayConnection(via, player, connection, channel)) {
-      packet.release();
-      return;
-    }
-
-    try {
-      channel.eventLoop().execute(() -> {
-        if (ViaConnectionGuard.isCurrentPlayConnection(via, player, connection, channel)) {
-          connection.sendRawPacket(packet);
-        } else {
-          packet.release();
-        }
-      });
-    } catch (RuntimeException | Error exception) {
-      packet.release();
-      throw exception;
-    }
+    assert channel != null; // checked by ViaConnectionGuard, field is final and will never change
+    channel.eventLoop().execute(() -> {
+      if (ViaConnectionGuard.isCurrentPlayConnection(via, player, connection)) {
+        connection.sendRawPacket(packet);
+      }
+    });
   }
 
   private @NotNull Integer teamsPacketId(final Player player, final UserConnection conn) {

implementation/src/main/java/net/megavex/scoreboardlibrary/implementation/packetAdapter/modern/util/ModernPacketSender.java

@@ -82,9 +82,10 @@ public void sendPacket(Player player, Object packet) {
       final UserConnection conn = this.via.getConnection(player.getUniqueId());
       if (conn != null) {
         final Channel channel = conn.getChannel();
-        if (!ViaConnectionGuard.isCurrentPlayConnection(this.via, player, conn, channel)) {
+        if (!ViaConnectionGuard.isCurrentPlayConnection(this.via, player, conn)) {
           return;
         }
+        assert channel != null; // checked by ViaConnectionGuard
 
         // Paper has some "network optimization" patch that makes the NMS sendPacket method
         // not always send the packet immediately to the player's netty channel,
@@ -96,7 +97,7 @@ public void sendPacket(Player player, Object packet) {
           // The player can disconnect or enter configuration while this write is queued. The
           // channel remains open in that state, but its encoder no longer accepts game packets.
           // Also guard against a reconnect replacing ViaVersion's UUID mapping in the meantime.
-          if (ViaConnectionGuard.isCurrentPlayConnection(this.via, player, conn, channel)) {
+          if (ViaConnectionGuard.isCurrentPlayConnection(this.via, player, conn)) {
             channel.writeAndFlush(packet);
           }
         });

implementation/src/main/java/net/megavex/scoreboardlibrary/implementation/packetAdapter/modern/util/ViaConnectionGuard.java

@@ -16,15 +16,7 @@ public static boolean isCurrentPlayConnection(
     Player player,
     UserConnection connection
   ) {
-    return isCurrentPlayConnection(via, player, connection, connection.getChannel());
-  }
-
-  public static boolean isCurrentPlayConnection(
-    ViaAPI<Player> via,
-    Player player,
-    UserConnection connection,
-    Channel channel
-  ) {
+    final Channel channel = connection.getChannel();
     final ProtocolInfo protocolInfo = connection.getProtocolInfo();
     return channel != null
       && player.isOnline()