chore: cleanup test cases to remove unused variables, improve expectations, and update deprecated API usage

Author: pavanpodila

packages/vyuh_node_flow/test/unit/controller/editor_init_api_test.dart

@@ -214,7 +214,8 @@ void main() {
           theme: NodeFlowTheme.light,
           portSizeResolver: (port) => const Size(10, 10),
           connectionHitTesterBuilder: (painter) {
-            receivedPainterWasNotNull = painter != null;
+            // painter is non-nullable, so this callback being invoked means we received a valid painter
+            receivedPainterWasNotNull = true;
             return (connection, point) => false;
           },
         );
@@ -699,6 +700,7 @@ void main() {
       expect(controller.isEditorInitialized, isTrue);
       expect(controller.theme, equals(NodeFlowTheme.light));
       expect(controller.events, equals(events));
+      expect(shapeBuilderCalled, isTrue);
       expect(hitTesterCalled, isTrue);
       expect(segmentCalculatorCalled, isTrue);
     });

packages/vyuh_node_flow/test/unit/editor/connections_layer_test.dart

@@ -868,13 +868,11 @@ void main() {
 
   group('Connection Style Builder', () {
     test('connectionStyleBuilder is called for each connection', () {
-      var callCount = 0;
       ConnectionStyle? styleBuilder(
         Connection connection,
         Node sourceNode,
         Node targetNode,
       ) {
-        callCount++;
         return ConnectionStyles.bezier;
       }
 

packages/vyuh_node_flow/test/unit/editor/element_scope_test.dart

@@ -1366,7 +1366,7 @@ void main() {
           home: Scaffold(
             body: ValueListenableBuilder<int>(
               valueListenable: counter,
-              builder: (context, _, __) {
+              builder: (context, _, _) {
                 return Center(
                   child: ElementScope(
                     onDragStart: _noOpDragStart,

packages/vyuh_node_flow/test/unit/editor/interaction_layer_test.dart

@@ -7,6 +7,7 @@
 /// - InteractionLayerPainter shouldRepaint logic
 /// - Canvas transform application
 /// - Edge cases and null states
+// ignore_for_file: deprecated_member_use
 @Tags(['unit'])
 library;
 
@@ -1491,10 +1492,8 @@ void main() {
       final startNode = controller.nodes['node-a'];
       expect(startNode, isNotNull);
 
-      final isStartFromOutput = true;
-      final portList = isStartFromOutput
-          ? startNode!.outputPorts
-          : startNode!.inputPorts;
+      // Starting from output - use output ports
+      final portList = startNode!.outputPorts;
 
       Port? startPort;
       for (final port in portList) {
@@ -1523,10 +1522,8 @@ void main() {
       final startNode = controller.nodes['node-b'];
       expect(startNode, isNotNull);
 
-      final isStartFromOutput = false;
-      final portList = isStartFromOutput
-          ? startNode!.outputPorts
-          : startNode!.inputPorts;
+      // Starting from input - use input ports
+      final portList = startNode!.inputPorts;
 
       Port? startPort;
       for (final port in portList) {
@@ -1559,17 +1556,14 @@ void main() {
       final controller = createTestController(nodes: [nodeA, nodeB]);
 
       // Simulate painter logic for finding hovered port
-      final isStartFromOutput = true;
       final targetNodeId = 'node-b';
       final targetPortId = 'input-1';
 
       final hoveredNode = controller.nodes[targetNodeId];
       expect(hoveredNode, isNotNull);
 
-      // Hovered port is the opposite type of start port
-      final portList = isStartFromOutput
-          ? hoveredNode!.inputPorts
-          : hoveredNode!.outputPorts;
+      // Starting from output, so hovered port should be an input
+      final portList = hoveredNode!.inputPorts;
 
       Port? hoveredPort;
       for (final port in portList) {
@@ -1602,17 +1596,14 @@ void main() {
       final controller = createTestController(nodes: [nodeA, nodeB]);
 
       // Simulate starting from input (node-b), hovering over output (node-a)
-      final isStartFromOutput = false;
       final targetNodeId = 'node-a';
       final targetPortId = 'output-1';
 
       final hoveredNode = controller.nodes[targetNodeId];
       expect(hoveredNode, isNotNull);
 
-      // Hovered port is the opposite type of start port (input -> output)
-      final portList = isStartFromOutput
-          ? hoveredNode!.inputPorts
-          : hoveredNode!.outputPorts;
+      // Starting from input, so hovered port should be an output
+      final portList = hoveredNode!.outputPorts;
 
       Port? hoveredPort;
       for (final port in portList) {

packages/vyuh_node_flow/test/unit/effects/gradient_particle_effects_test.dart

@@ -371,13 +371,12 @@ void main() {
         effect.paint(canvas, path, basePaint, 0.5);
 
         // With 0 opacity, base path should not be drawn
-        // Only gradient segment should be drawn
-        final pathOps = canvas.operations.whereType<DrawPathOperation>();
-        for (final op in pathOps) {
-          // Any visible paths should have shader (gradient) or be the gradient segment
-          // The base path with 0 opacity should not be drawn
-        }
-        expect(canvas.operations, isNotEmpty);
+        // Only gradient segment should be drawn - verify we have path operations
+        expect(
+          canvas.operations.whereType<DrawPathOperation>(),
+          isNotEmpty,
+          reason: 'Gradient segment should still be drawn',
+        );
       });
 
       test('connectionOpacity 1 shows full base connection', () {
@@ -871,7 +870,10 @@ void main() {
             .whereType<DrawCircleOperation>()
             .toList();
         // Compare Color values (MaterialColor wraps a Color)
-        expect(circleOps[0].paint.color.value, equals(Colors.red.value));
+        expect(
+          circleOps[0].paint.color.toARGB32(),
+          equals(Colors.red.toARGB32()),
+        );
       });
 
       test('uses base paint color when no custom color', () {
@@ -889,7 +891,10 @@ void main() {
             .whereType<DrawCircleOperation>()
             .toList();
         // Compare Color values (MaterialColor wraps a Color)
-        expect(circleOps[0].paint.color.value, equals(Colors.green.value));
+        expect(
+          circleOps[0].paint.color.toARGB32(),
+          equals(Colors.green.toARGB32()),
+        );
       });
 
       test('circle particle size is correct', () {
@@ -977,7 +982,10 @@ void main() {
             .toList();
         // Last path op should be the arrow
         // Compare Color values (MaterialColor wraps a Color)
-        expect(pathOps.last.paint.color.value, equals(Colors.purple.value));
+        expect(
+          pathOps.last.paint.color.toARGB32(),
+          equals(Colors.purple.toARGB32()),
+        );
       });
 
       test('arrow particle size reflects dimensions', () {

packages/vyuh_node_flow/test/unit/effects/pulse_effect_test.dart

@@ -332,7 +332,8 @@ void main() {
     });
 
     test('pulse calculation is mathematically correct', () {
-      final effect = PulseEffect(minOpacity: 0.0, maxOpacity: 1.0);
+      // This test verifies the math used in PulseEffect for calculating pulse progress
+      // The effect uses: pulseProgress = (sin(animationValue * 2 * pi) + 1) / 2
 
       // pulseProgress at animationValue 0:
       // (sin(0) + 1) / 2 = (0 + 1) / 2 = 0.5

packages/vyuh_node_flow/test/unit/events/node_flow_events_test.dart

@@ -601,9 +601,9 @@ void main() {
 
   group('Events Integration', () {
     test('controller setEvents applies events correctly', () {
-      Node<String>? tappedNode;
+      var tapCount = 0;
       void onTap(Node<String> node) {
-        tappedNode = node;
+        tapCount++;
       }
 
       final controller = createTestController();
@@ -612,6 +612,10 @@ void main() {
       );
 
       expect(controller.events.node?.onTap, isNotNull);
+      // Verify the callback is wired correctly by invoking it
+      final testNode = createTestNode(id: 'test');
+      controller.events.node?.onTap?.call(testNode);
+      expect(tapCount, equals(1));
     });
 
     test('node events fire correctly', () {

packages/vyuh_node_flow/test/unit/extensions/debug_overlays_test.dart

@@ -5,6 +5,7 @@
 /// - SpatialIndexDebugPainter properties and shouldRepaint logic
 /// - AutopanZoneDebugLayer construction and conditional rendering
 /// - DebugTheme integration with painters
+// ignore_for_file: deprecated_member_use
 @Tags(['unit'])
 library;
 

packages/vyuh_node_flow/test/unit/extensions/minimap_widget_test.dart

@@ -272,8 +272,6 @@ void main() {
 
       await tester.pumpAndSettle();
 
-      final initialViewport = controller.viewport;
-
       // Tap on the minimap
       await tester.tap(find.byType(NodeFlowMinimap<String>));
       await tester.pumpAndSettle();

packages/vyuh_node_flow/test/unit/graph/graph_test.dart

@@ -796,7 +796,8 @@ void main() {
         final groupNodes = mixedGraph.getGroupNodes();
 
         expect(groupNodes.length, equals(2));
-        expect(groupNodes.every((n) => n is GroupNode<String>), isTrue);
+        // getGroupNodes returns List<GroupNode<T>>, so all elements are GroupNodes
+        expect(groupNodes, everyElement(isA<GroupNode<String>>()));
         expect(
           groupNodes.map((n) => n.id),
           containsAll(['group-1', 'group-2']),
@@ -819,7 +820,8 @@ void main() {
         final commentNodes = mixedGraph.getCommentNodes();
 
         expect(commentNodes.length, equals(1));
-        expect(commentNodes.every((n) => n is CommentNode<String>), isTrue);
+        // getCommentNodes returns List<CommentNode<T>>, so all elements are CommentNodes
+        expect(commentNodes, everyElement(isA<CommentNode<String>>()));
         expect(commentNodes.first.id, equals('comment-1'));
       });