test: refine shouldRepaint behavior and update connection endpoint visibility tests

Author: pavanpodila

packages/vyuh_node_flow/test/unit/editor/connections_layer_test.dart

@@ -182,7 +182,7 @@ void main() {
   // ===========================================================================
 
   group('ConnectionsCanvas shouldRepaint', () {
-    test('shouldRepaint always returns true', () {
+    test('shouldRepaint returns false when fingerprint and theme match', () {
       final controller = createTestController();
       final painter = createTestConnectionPainter(theme: NodeFlowTheme.light);
 
@@ -198,11 +198,11 @@ void main() {
         connectionPainter: painter,
       );
 
-      // shouldRepaint should always return true for MobX reactivity
-      expect(canvas1.shouldRepaint(canvas2), isTrue);
+      // shouldRepaint returns false when fingerprint and theme are identical
+      expect(canvas1.shouldRepaint(canvas2), isFalse);
     });
 
-    test('shouldRepaint returns true even with same references', () {
+    test('shouldRepaint returns false with same canvas instance', () {
       final controller = createTestController();
       final painter = createTestConnectionPainter(theme: NodeFlowTheme.light);
 
@@ -212,8 +212,8 @@ void main() {
         connectionPainter: painter,
       );
 
-      // Same canvas instance
-      expect(canvas.shouldRepaint(canvas), isTrue);
+      // Same canvas instance has same fingerprint and theme
+      expect(canvas.shouldRepaint(canvas), isFalse);
     });
 
     test('shouldRepaint returns true with different themes', () {
@@ -235,7 +235,7 @@ void main() {
       expect(canvas1.shouldRepaint(canvas2), isTrue);
     });
 
-    test('shouldRepaint returns true with different controllers', () {
+    test('shouldRepaint returns false with different empty controllers', () {
       final controller1 = createTestController();
       final controller2 = createTestController();
       final painter = createTestConnectionPainter(theme: NodeFlowTheme.light);
@@ -252,6 +252,42 @@ void main() {
         connectionPainter: painter,
       );
 
+      // Empty controllers have the same fingerprint (no connections)
+      expect(canvas1.shouldRepaint(canvas2), isFalse);
+    });
+
+    test('shouldRepaint returns true when connections change', () {
+      final controller = createTestController();
+      final painter = createTestConnectionPainter(theme: NodeFlowTheme.light);
+
+      // Add nodes with ports for connections
+      final node1 = createTestNodeWithPorts(id: 'n1');
+      final node2 = createTestNodeWithPorts(id: 'n2');
+      controller.addNode(node1);
+      controller.addNode(node2);
+
+      final canvas1 = ConnectionsCanvas<String, dynamic>(
+        store: controller,
+        theme: NodeFlowTheme.light,
+        connectionPainter: painter,
+      );
+
+      // Add a connection to change the fingerprint
+      controller.addConnection(Connection(
+        id: 'c1',
+        sourceNodeId: 'n1',
+        sourcePortId: node1.outputPorts.first.id,
+        targetNodeId: 'n2',
+        targetPortId: node2.inputPorts.first.id,
+      ));
+
+      final canvas2 = ConnectionsCanvas<String, dynamic>(
+        store: controller,
+        theme: NodeFlowTheme.light,
+        connectionPainter: painter,
+      );
+
+      // Fingerprint changed due to new connection
       expect(canvas1.shouldRepaint(canvas2), isTrue);
     });
   });

packages/vyuh_node_flow/test/unit/lod/detail_visibility_test.dart

@@ -95,7 +95,10 @@ void main() {
         expect(visibility.showPorts, isFalse);
         expect(visibility.showPortLabels, isFalse);
         expect(visibility.showConnectionLabels, isFalse);
-        expect(visibility.showConnectionEndpoints, isFalse);
+        expect(
+          visibility.showConnectionEndpoints,
+          isTrue,
+        ); // Kept for visibility
         expect(visibility.showResizeHandles, isFalse);
       });
 
@@ -126,7 +129,10 @@ void main() {
         expect(visibility.showPorts, isFalse);
         expect(visibility.showPortLabels, isFalse);
         expect(visibility.showConnectionLabels, isFalse);
-        expect(visibility.showConnectionEndpoints, isFalse);
+        expect(
+          visibility.showConnectionEndpoints,
+          isTrue,
+        ); // Kept for visibility
         expect(visibility.showResizeHandles, isFalse);
       });
 
@@ -371,7 +377,7 @@ void main() {
       expect(copy.showPortLabels, isFalse); // Unchanged from minimal
       expect(copy.showConnectionLines, isTrue); // Unchanged from minimal
       expect(copy.showConnectionLabels, isFalse); // Unchanged from minimal
-      expect(copy.showConnectionEndpoints, isFalse); // Unchanged from minimal
+      expect(copy.showConnectionEndpoints, isTrue); // Unchanged from minimal
       expect(copy.showResizeHandles, isTrue);
     });
 
@@ -407,7 +413,8 @@ void main() {
         showPortLabels: false,
         showConnectionLines: true,
         showConnectionLabels: false,
-        showConnectionEndpoints: false,
+        showConnectionEndpoints: true,
+        // minimal keeps endpoints visible
         showResizeHandles: false,
       );
 
@@ -426,7 +433,7 @@ void main() {
       expect(result.showPortLabels, isFalse);
       expect(result.showConnectionLines, isTrue);
       expect(result.showConnectionLabels, isFalse);
-      expect(result.showConnectionEndpoints, isFalse);
+      expect(result.showConnectionEndpoints, isTrue); // minimal keeps endpoints
       expect(result.showResizeHandles, isTrue);
     });
   });
@@ -651,7 +658,10 @@ void main() {
       expect(string, contains('showPortLabels: false'));
       expect(string, contains('showConnectionLines: true'));
       expect(string, contains('showConnectionLabels: false'));
-      expect(string, contains('showConnectionEndpoints: false'));
+      expect(
+        string,
+        contains('showConnectionEndpoints: true'),
+      ); // minimal keeps endpoints
       expect(string, contains('showResizeHandles: false'));
     });
 

packages/vyuh_node_flow/test/unit/lod/lod_state_test.dart

@@ -28,7 +28,7 @@ void main() {
         isTrue,
       ); // Kept for graph structure
       expect(visibility.showConnectionLabels, isFalse);
-      expect(visibility.showConnectionEndpoints, isFalse);
+      expect(visibility.showConnectionEndpoints, isTrue); // Kept for visibility
       expect(visibility.showResizeHandles, isFalse);
     });
 
@@ -40,7 +40,7 @@ void main() {
       expect(visibility.showPortLabels, isFalse);
       expect(visibility.showConnectionLines, isTrue);
       expect(visibility.showConnectionLabels, isFalse);
-      expect(visibility.showConnectionEndpoints, isFalse);
+      expect(visibility.showConnectionEndpoints, isTrue); // Kept for visibility
       expect(visibility.showResizeHandles, isFalse);
     });