[css-values-5] Fix and rename random grammar#13827
Closed
Conversation
Follow-up to 33682af.
Collaborator
|
I think this problem is fixed in https://github.com/w3c/csswg-drafts/pull/13845/changes ? Or is something still broken? |
Collaborator
Author
|
Yes, it is fixed by #13845. Not exactly something broken, but some things that generally seem to lack precision:
https://drafts.csswg.org/css-values-5/#typedef-random-cache-key But I assume these will be fixed as you refine these terms and definitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
random-*()grammar is slightly broken since 33682af.They now take a
<random-key>argument renamed from<random-cache-key>. It still producesauto | <random-name> | fixed <number [0,1)>but<random-name>is left undefined, because its definition and production rule now use<random-cache-key>, which was probably not intentional.This PR tries to fix this but since
fixed <number [0,1)>is not a random (cache) key but a random base value, and sinceautoproduces but is not a random name, and resolves to a random base value, I suggest to introduce<random-base-value>to replace<random-key>.