Add download id to download events.#1117
Merged
Merged
Conversation
jgraham
approved these changes
May 12, 2026
Member
|
The Browser Testing and Tools Working Group just discussed The full IRC log of that discussion<jgraham> Topic: Add download ID field to download events<jgraham> github: https://github.com//pull/1117 <jgraham> RRSAgent: make logs public <RRSAgent> I have made the request, jgraham <tidoust> sasha: The load event only has navigation ID, which is fine for most cases. In the case when it's not present, it makes it impossible to link start/end loading events. <tidoust> s/load/download <tidoust> ... I created a PR for that which shouldn't be controversial. Comments welcome. <orkon> q+ <jgraham> ack next <tidoust> ack orkon <tidoust> orkon: I think it looks fine and that we should have a download ID. I'll take another look next week. |
OrKoN
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1096.
Motivation:
downloadWillBeginanddownloadEndevents in case the navigation id is missing.The PR in the HTML spec to pass
downloadResponseto events: whatwg/html#12426.Preview | Diff