Skip to content

Throw "invalid cookie domain" as its definition implies #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whimboo merged 2 commits into from
Apr 1, 2026
Merged

Throw "invalid cookie domain" as its definition implies #1955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53018d9
Throw "invalid cookie domain" instead
yezhizhen Mar 26, 2026
555772e
Move type check earlier
yezhizhen Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7603,20 +7603,20 @@ <h3><dfn data-lt="adding a cookie">Add Cookie</dfn></h3>
<li><p><a>Try</a> to <a>handle any user prompts</a>
with <var>session</var>.

<li><p>If <var>session</var>&apos;s <a>current browsing
context</a>&apos;s <a>document element</a> is
a <a>cookie-averse <code>Document</code> object</a>,
return <a>error</a> with <a>error code</a> <a>invalid cookie
domain</a>.

<li><p>If <a>cookie name</a> or <a>cookie value</a> is <a><code>null</code></a>,
<a>cookie domain</a> is not equal to <var>session</var>&apos;s <a>current
browsing context</a>&apos;s <a>active document</a>&apos;s <a>domain</a>,
<li><p>If <a>cookie name</a> or <a>cookie value</a> is <a><code>null</code></a>,
<a>cookie secure only</a> or <a>cookie HTTP only</a> are not boolean types,
or <a>cookie expiry time</a> is not an integer type, or it less than 0 or greater than
the <a>maximum safe integer</a>, return <a>error</a> with <a>error
code</a> <a>invalid argument</a>.

<li><p>If <var>session</var>&apos;s <a>current browsing
context</a>&apos;s <a>document element</a> is
a <a>cookie-averse <code>Document</code> object</a> or
<a>cookie domain</a> is not equal to <var>session</var>&apos;s <a>current
browsing context</a>&apos;s <a>active document</a>&apos;s <a>domain</a>,
return <a>error</a> with <a>error code</a> <a>invalid cookie
domain</a>.

<li><p><a>Create a cookie</a> in
the <a>cookie store</a> associated with
the <a>active document</a>&apos;s <a>address</a>
Expand Down
Loading