Add network typedefs to start cross-platform support#6
Merged
Conversation
OmniBlade
requested changes
Aug 4, 2025
Collaborator
|
This PR for the GamespySDK should hopefully fix the winsock/winsock2 include errors. Once merged the commit will need bumping in gamespy.cmake. |
Collaborator
|
@rm5248 I've merged the gamespy fix, so you can bump the commit we fetch now. That should be all you need to do. |
rm5248
force-pushed
the
network-typedefs
branch
from
d93b41b to
2439e7e
Compare
Collaborator
Author
Hmm.. still seems broken according to CI. I'm not quite sure where to go from here. |
Collaborator
|
@rm5248 My fault for not being specific enough, I merged the fix into the GameSpySDK repo, the commit hash needs updating in this repo in gamespy.cmake so it fetches the newer commit. You might as well do in this PR if that is okay. |
Merged
rm5248
force-pushed
the
network-typedefs
branch
from
2439e7e to
696c352
Compare
OmniBlade
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.