fix(mobile-buttons): prevent buttons from overflowing screen#2680
Closed
gholi-dev wants to merge 1 commit into
Closed
fix(mobile-buttons): prevent buttons from overflowing screen#2680gholi-dev wants to merge 1 commit into
gholi-dev wants to merge 1 commit into
Conversation
Contributor
|
CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Please submit the following text as a separate comment: I have read and hereby sign the Contributor License Agreement. You can retrigger this bot by commenting recheck in this Pull Request |
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
Hey @gholi-dev, thanks for bringing this to my attention. However, this solution also seems to break the layout as the buttons become shorter than the text and won't wrap further than to two lines. I appreciate the effort, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is not a grant application.
It only fixes a minor UI bug where homepage buttons were overflowing on mobile screens.
Changes
Result
Buttons are now correctly displayed within the mobile viewport.