Skip to content

Commit 26bf955

Browse files
authored
Merge pull request #51 from wafflestudio/haram
fix: default img, name setting logic
2 parents d815287 + 6ef70c8 commit 26bf955

7 files changed

Lines changed: 296 additions & 286 deletions

File tree

src/pages/CalendarView.tsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,15 @@ const CalendarView = () => {
7979
await fetchMonthEvents(paramMonth);
8080
};
8181
loadMonthEvents();
82-
}, [currentDate, fetchMonthEvents, globalCategory, globalOrg, globalStatus, excludedKeywords, interestCategories]);
82+
}, [
83+
currentDate,
84+
fetchMonthEvents,
85+
globalCategory,
86+
globalOrg,
87+
globalStatus,
88+
excludedKeywords,
89+
interestCategories,
90+
]);
8391

8492
useEffect(() => {
8593
const getWeekRangeByDate = (date: Date) => {

src/pages/auth/OnBoarding/ProfileSetting.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,23 @@ export default function ProfileSetting() {
99
const [, setSearchParams] = useSearchParams();
1010
const { updateUser } = useAuth();
1111

12-
const DEFAULT_PROFILE_URL = defaultProfile;
12+
const defaultName = "푱푱한 토끼";
1313
const [name, setName] = useState<string>("");
14-
const [previewUrl, setPreviewUrl] = useState(DEFAULT_PROFILE_URL);
14+
const [previewUrl, setPreviewUrl] = useState(defaultProfile);
1515
const [imgFile, setImgFile] = useState<File | null>(null);
16-
const [, setIsDefaultProfile] = useState(true);
1716

1817
const handleImageChange = (e: React.ChangeEvent<HTMLInputElement>) => {
1918
const file = e.target.files?.[0];
2019
if (!file) return;
2120
setImgFile(file);
2221
setPreviewUrl(URL.createObjectURL(file));
23-
setIsDefaultProfile(false);
2422
};
2523

26-
const handleSubmit = (e: React.FormEvent<HTMLFormElement>) => {
24+
const handleSubmit = async (e: React.FormEvent<HTMLFormElement>) => {
2725
e.preventDefault();
28-
updateUser(name, imgFile);
26+
const finalName = name.trim() === "" ? defaultName : name.trim();
27+
28+
await updateUser(finalName, imgFile);
2929

3030
setSearchParams((prev) => {
3131
const next = new URLSearchParams(prev);
@@ -34,7 +34,6 @@ export default function ProfileSetting() {
3434
});
3535
};
3636

37-
// profile image preview url cleanup (cleanup callback is executed before next effect / component unmount)
3837
useEffect(() => {
3938
return () => {
4039
if (previewUrl?.startsWith("blob:")) {
@@ -77,7 +76,7 @@ export default function ProfileSetting() {
7776
/>
7877

7978
<button className={styles.submit} type="submit">
80-
닉네임 설정하기
79+
완료
8180
</button>
8281
</form>
8382
</div>

src/pages/bookmark/Bookmark.tsx

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -45,38 +45,38 @@ const BookmarksPage = () => {
4545
const { showDetail, clickedEventId } = useDetail();
4646

4747
return (
48-
<div className={styles.container}>
49-
<div className={styles.bookmarksPage}>
50-
<Navigationbar />
51-
<div className={styles.bookmarksHeader}>
52-
<FaChevronLeft
53-
className={styles.backBtn}
54-
color="ABABAB"
55-
size={18}
56-
onClick={() => navigate("/my")}
57-
/>
58-
<div className={styles.row}>
59-
<span>내 찜 목록</span>
60-
<img src="/assets/Bookmarked.svg" alt="filled bookmark icon" />
61-
</div>
48+
<div className={styles.container}>
49+
<div className={styles.bookmarksPage}>
50+
<Navigationbar />
51+
<div className={styles.bookmarksHeader}>
52+
<FaChevronLeft
53+
className={styles.backBtn}
54+
color="ABABAB"
55+
size={18}
56+
onClick={() => navigate("/my")}
57+
/>
58+
<div className={styles.row}>
59+
<span>내 찜 목록</span>
60+
<img src="/assets/Bookmarked.svg" alt="filled bookmark icon" />
6261
</div>
63-
<div className={styles.cardsColumn}>
64-
{bookmarkedEvents &&
65-
bookmarkedEvents.length > 0 &&
66-
bookmarkedEvents.map((e) => <GalleryCard key={e.id} event={e} />)}
67-
</div>
68-
{(!bookmarkedEvents || bookmarkedEvents.length === 0) && (
69-
<span
70-
className={styles.noneText}
71-
>{`아직 찜된 행사가 없습니다.\n관심있는 행사를 찜해보세요!`}</span>
72-
)}
7362
</div>
74-
{showDetail && clickedEventId !== undefined && (
75-
<div className={styles.sidePanel}>
76-
<DetailView eventId={clickedEventId} />
77-
</div>
63+
<div className={styles.cardsColumn}>
64+
{bookmarkedEvents &&
65+
bookmarkedEvents.length > 0 &&
66+
bookmarkedEvents.map((e) => <GalleryCard key={e.id} event={e} />)}
67+
</div>
68+
{(!bookmarkedEvents || bookmarkedEvents.length === 0) && (
69+
<span
70+
className={styles.noneText}
71+
>{`아직 찜된 행사가 없습니다.\n관심있는 행사를 찜해보세요!`}</span>
7872
)}
7973
</div>
74+
{showDetail && clickedEventId !== undefined && (
75+
<div className={styles.sidePanel}>
76+
<DetailView eventId={clickedEventId} />
77+
</div>
78+
)}
79+
</div>
8080
);
8181
};
8282

0 commit comments

Comments
 (0)