-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 임시멤버(명부) 일괄 생성 엔드포인트 POST /users/temporary #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
youngunghan
wants to merge
4
commits into
main
Choose a base branch
from
feat/temp-member-import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9126e3e
feat: add temporary member roster import (POST /users/temporary)
youngunghan 773cc21
feat: parse roster .xlsx on the backend (file upload)
youngunghan 36944b0
feat: accept .csv rosters and add Korean validation messages
youngunghan dec9dc7
Merge remote-tracking branch 'origin/main' into feat/temp-member-import
youngunghan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| """add temporary member support | ||
|
|
||
| Make users.email nullable (temporary members have no OAuth email) and add an | ||
| is_temporary flag plus supporting indexes for roster import. | ||
|
|
||
| Revision ID: a1b2c3d4e5f6 | ||
| Revises: c951e903b294 | ||
| Create Date: 2026-06-28 00:00:00.000000 | ||
|
|
||
| """ | ||
|
|
||
| from typing import Sequence, Union | ||
|
|
||
| import sqlalchemy as sa | ||
|
|
||
| from alembic import op | ||
|
|
||
| revision: str = "a1b2c3d4e5f6" | ||
| # Re-parented onto main's approval-requests migration after merging origin/main, | ||
| # so the two feature branches form a single linear history (no alembic fork). | ||
| down_revision: Union[str, None] = "c951e903b294" | ||
| branch_labels: Union[str, Sequence[str], None] = None | ||
| depends_on: Union[str, Sequence[str], None] = None | ||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| op.alter_column( | ||
| "users", | ||
| "email", | ||
| existing_type=sa.String(length=255), | ||
| nullable=True, | ||
| ) | ||
| op.add_column( | ||
| "users", | ||
| sa.Column( | ||
| "is_temporary", | ||
| sa.Boolean(), | ||
| nullable=False, | ||
| server_default="0", | ||
| ), | ||
| ) | ||
| op.create_index("idx_users_is_temporary", "users", ["is_temporary"]) | ||
| op.create_index("idx_users_student_id", "users", ["student_id"]) | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| op.drop_index("idx_users_student_id", table_name="users") | ||
| op.drop_index("idx_users_is_temporary", table_name="users") | ||
| op.drop_column("users", "is_temporary") | ||
| # Reverting email to NOT NULL requires no rows with NULL email. | ||
| op.alter_column( | ||
| "users", | ||
| "email", | ||
| existing_type=sa.String(length=255), | ||
| nullable=False, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 row 크기 말고는 입력 크기 제한이 없는데, 용량 기준으로도 제한하는 게 좋을 것 같습니다.