Allow users with edit access to pages / snippets via workflows to access ping endpoint#12237
Merged
Merged
Conversation
…granted access to the ping endpoint
…re granted access to the ping endpoint Fixes wagtail#12209
gasman
added
type:Bug
Manage this branch in SquashTest this branch here: https://gasmanfixediting-session-ping-ycku5.squash.io |
laymonage
approved these changes
Aug 20, 2024
Member
laymonage
left a comment
laymonage
left a comment
There was a problem hiding this comment.
Tested and works as expected, looks good to me – thanks!
Comment on lines
+38
to
+48
| can_edit = permission_policy.user_has_permission_for_instance( | ||
| request.user, "change", obj | ||
| ) | ||
| if not can_edit and isinstance(obj, WorkflowMixin): | ||
| workflow = obj.get_workflow() | ||
| if workflow is not None: | ||
| current_workflow_task = obj.current_workflow_task | ||
| can_edit = ( | ||
| current_workflow_task | ||
| and current_workflow_task.user_can_access_editor(obj, request.user) | ||
| ) |
Member
There was a problem hiding this comment.
I suppose an alternative is to include this logic directly in ModelPermissionPolicy.user_has_permission_for_instance(), and reuse it for the edit view, but at this point I think it's better to wait for wagtail/rfcs#102.
gasman
added a commit
that referenced
this pull request
Aug 20, 2024
gasman
added a commit
that referenced
this pull request
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12209