Fix row an col calculation for win without borders#20
Fix row an col calculation for win without borders#20cgimenes wants to merge 1 commit intowaiting-for-dev:mainfrom
Conversation
|
Just curious, how did you notice that? 🙂 |
Basically, I was trying to replace Snacks lazygit with ergoterm and saw that Snacks doesn't add borders to the floating terminal. |
|
But was it actually a problem that the border extended by one extra row/column? I’m wondering whether we can treat the current row/column definition as already encompassing the border, just to keep things simpler. |
Forget about it, I got confused with width/height 😓 |
|
Thanks for your collaboration. Your change has been merged in 5637531. I needed to make some changes to add tests and avoid overriding user explicit preferences but I couldn't directly push to your branch. |
No description provided.