Skip to content

Fix row an col calculation for win without borders#20

Closed
cgimenes wants to merge 1 commit intowaiting-for-dev:mainfrom
cgimenes:main
Closed

Fix row an col calculation for win without borders#20
cgimenes wants to merge 1 commit intowaiting-for-dev:mainfrom
cgimenes:main

Conversation

@cgimenes
Copy link
Copy Markdown
Contributor

No description provided.

@waiting-for-dev
Copy link
Copy Markdown
Owner

Just curious, how did you notice that? 🙂

@cgimenes
Copy link
Copy Markdown
Contributor Author

Just curious, how did you notice that? 🙂

Basically, I was trying to replace Snacks lazygit with ergoterm and saw that Snacks doesn't add borders to the floating terminal.

@waiting-for-dev
Copy link
Copy Markdown
Owner

But was it actually a problem that the border extended by one extra row/column? I’m wondering whether we can treat the current row/column definition as already encompassing the border, just to keep things simpler.

@waiting-for-dev
Copy link
Copy Markdown
Owner

But was it actually a problem that the border extended by one extra row/column? I’m wondering whether we can treat the current row/column definition as already encompassing the border, just to keep things simpler.

Forget about it, I got confused with width/height 😓

@waiting-for-dev
Copy link
Copy Markdown
Owner

waiting-for-dev commented Nov 26, 2025

Thanks for your collaboration. Your change has been merged in 5637531. I needed to make some changes to add tests and avoid overriding user explicit preferences but I couldn't directly push to your branch.

@waiting-for-dev waiting-for-dev added the bug Something isn't working label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants