Surfaced via Copilot review on PR #493 (which has since merged):
logging.properties appears to be a broken/missing file in this module (it shows up in the directory listing but can'''t be read, consistent with a broken symlink), so this <include> currently won'''t package anything. Consider either adding a real logging.properties file (or fixing the symlink) or removing this include to avoid future confusion about what'''s actually shipped.
Confirmed: jython/com.ibm.wala.cast.python.jython3.test/logging.properties is a symlink to ../logging.properties, which doesn'''t exist. The PR #493 fix scoped the build resource to include META-INF/**, build.properties, and logging.properties — but the third entry is a no-op because Maven silently skips broken symlinks.
The PR'''s fix is correct and works (the recursive-target bug is gone), but the logging.properties include is dead weight today. Small follow-up: pick one of:
- Drop the
<include>logging.properties</include> line — minimal diff; preserves current packaging behavior (the symlink was never being followed by Maven anyway).
- Fix the symlink to point at an actual logging-config file. This module is jython3 testing infrastructure; if a logging-config is intended, it should live somewhere reachable. The fork'''s
ponder-lab/ML master HAS a real logging.properties at the repo root that could be the symlink target.
Either is acceptable; (1) is cleaner if no logging config is needed; (2) preserves the original-author intent if the missing file is the bug. I'd lean (1) in the absence of evidence that a logging config was meaningfully used here.
Out of scope for the original #493 (already merged); filed as a tracked follow-up.
Surfaced via Copilot review on PR #493 (which has since merged):
Confirmed:
jython/com.ibm.wala.cast.python.jython3.test/logging.propertiesis a symlink to../logging.properties, which doesn'''t exist. The PR #493 fix scoped the build resource to includeMETA-INF/**,build.properties, andlogging.properties— but the third entry is a no-op because Maven silently skips broken symlinks.The PR'''s fix is correct and works (the recursive-target bug is gone), but the
logging.propertiesinclude is dead weight today. Small follow-up: pick one of:<include>logging.properties</include>line — minimal diff; preserves current packaging behavior (the symlink was never being followed by Maven anyway).ponder-lab/MLmaster HAS a reallogging.propertiesat the repo root that could be the symlink target.Either is acceptable; (1) is cleaner if no logging config is needed; (2) preserves the original-author intent if the missing file is the bug. I'd lean (1) in the absence of evidence that a logging config was meaningfully used here.
Out of scope for the original #493 (already merged); filed as a tracked follow-up.