Perf/large dataset#130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve large dataset performance for GridSheet. Previously the grid already supported large datasets, but initialization was slow due to upfront data formatting. This PR introduces lazy initialization and deferred cell expansion to avoid blocking the UI during initial render. A loading overlay provides feedback during heavy mutations. Several bugs are also fixed: IME composition handling, blank space after sheet resize, sheet edge selection, and tabular size clamping.
Type of Change
Impact Area
packages/core/src/lib/sheet.ts— Major refactor for lazy initialization and deferred matrix cell expansion. Reviewers should pay close attention here.packages/core/src/lib/spatial.ts/virtualization.ts— Adjustments for large grid support and edge selection fixes.packages/react-core/src/components/GridSheet.tsx— Loading overlay integration and resize observer fixes.packages/react-core/src/components/Tabular.tsx— Tabular size clamping to content bounds.packages/react-core/src/components/Editor.tsx/FormulaBar.tsx— IME composition fix.packages/react-core/src/store/actions.ts— New actions for loading state management.packages/storybook/stories/basic/huge.stories.tsx— New story for testing large datasets.How Has This Been Tested?
pnpm storybookpnpm testpnpm lint:fix