feat: GDrive File Scope implementation with file picker#86
Conversation
This will serve to replace the GenClientId process by using commandLine args to pass values to be inlined into the plugin
This allows us to grant access to specific files to our application, instead of granting global access. That'll help us get around both the google blocking issue, and the kdbx file duplication issue when using limited file scope The UI elements wrapping around this will be added in a later commit
This PR adds a UI element that displays a cancellation button, and calls the file picker service. This will allows us to add a button in the plugin config that makes this form show up and redirect the user to their browser
Since we've already implemented a new process to read some configuration items from build params, we no longer need the T4 generation to build the clientId into the app
This flow will allow us to build and upload our artifacts whenever we cut a new release. It also lays the groundwork for simplifying how we manage autoupdate files
This will allow the plugin to be built from any repo without code changes, and allows us to have the auto-update file in our release artifacts instead of the repo
retlok
left a comment
retlok
left a comment
There was a problem hiding this comment.
My knowledge of C# is limited because I'm mainly a java dev, but I don't see anything sketchy, and I've tested this E2E so it looks good to me
Would we need to change these if we were to use your compiled plugin ? Hoping this PR gets implemented since my entire workflow using this plugin and keepass has suffered since the google changes. Thank you @desmaraisp for working on this ❤️ |
Only if you want to build the plugin yourself (ie when this is merged, we'll need to add the values to the repo's vars). People installing the plugin shouldn't need to touch that at all |
|
This was a life saver ! Thanks @desmaraisp for fixing the issue. @walterpg any chance this PR can be merged and a new official release cut ? |
|
I was syncing between android and PC KPSyncForDrive-5.0.0 still creating duplicate directories/files EXCEPT WHEN Deleted kdbx file from the duplicate folder and moved kdbx from where it was being synced by android to this new duplicate folder and it seemed to sync.I will update when I sync between devices several times 
|
|
Renamed old Gdrive folder. Leaving dup as only folder with valid kdbx file. Sync from android then PC all data present. First time executing KeePass on PC. The KeePass update check reported that |
|
Heya, a couple of notes
|
5 participants
This PR reimplements #51, which aimed to fix #79. With this PR, the plugin uses the file scope only, avoiding the "Google blocked this access issue", without requiring any App Review from Google. It also adds a new button in the plugin config that serves to grant access to existing files in the gDrive so that we can avoid creating duplicate files when syncing across multiple devices
You can find a compiled release of the plugin here: KPSyncForDrive-5.0.0.zip, using my own ClientId, certificate and AutoUpdate Url