Commit d033e71
authored
style: apply /style-guide pass to support/weave/articles (#2671)
## Summary
This PR applies an automated `/style-guide` pass (Google Developer Style
Guide + CoreWeave conventions) to 16 FAQ articles under
`support/weave/articles`. The run was automated; changes are style-only
and require a technical reviewer to validate any items flagged below.
## Files edited
- `support/weave/articles/how-can-i-disable-client-information-cap.mdx`
- `support/weave/articles/how-can-i-disable-code-capture.mdx`
- `support/weave/articles/how-can-i-disable-system-information-cap.mdx`
- `support/weave/articles/how-do-i-render-markdown-in-the-ui.mdx`
- `support/weave/articles/how-do-i-render-python-datetime-values-i.mdx`
- `support/weave/articles/how-is-weave-data-ingestion-calculated.mdx`
- `support/weave/articles/long-eval-clean-up-times.mdx`
- `support/weave/articles/os-errors-too-many-open-files.mdx`
- `support/weave/articles/server-response-caching.mdx`
- `support/weave/articles/trace-data-is-truncated.mdx`
- `support/weave/articles/trace-data-loss-in-worker-processes.mdx`
- `support/weave/articles/trace-pages-load-slowly.mdx`
- `support/weave/articles/weave-call-does-not-raise-exceptions.mdx`
- `support/weave/articles/what-information-does-weave-capture-for.mdx`
- `support/weave/articles/what-is-pairwise-evaluation-and-how-do-i.mdx`
- `support/weave/articles/will-weave-affect-my-function-s-executio.mdx`
## Recommendations for technical review
### Technical accuracy — SDK surface and option names
- Confirm `settings={"capture_client_info": False}`,
`settings={"capture_code": False}`, and
`settings={"capture_system_info": False}` are the current, canonical
shapes for passing these options to `weave.init()` (vs. top-level
keyword arguments, environment variables, or a separate settings API).
Also confirm the exact key names (`capture_client_info`, `capture_code`,
`capture_system_info`). See
`how-can-i-disable-client-information-cap.mdx`,
`how-can-i-disable-code-capture.mdx`,
`how-can-i-disable-system-information-cap.mdx`.
- Confirm whether a `WEAVE_CAPTURE_SYSTEM_INFO` (or similar) environment
variable exists for parity with `WEAVE_CAPTURE_CODE`, and document it if
so (`how-can-i-disable-system-information-cap.mdx`).
- Confirm `weave.init("entity/project", …)` is the canonical example
signature and that `entity/project` (and `"[TEAM-NAME]/[PROJECT-NAME]"`
in `trace-data-loss-in-worker-processes.mdx`) is the recommended
placeholder format.
- Confirm `weave.publish(...)` is the correct surface for publishing a
`datetime.datetime` with `tzinfo`, and that Weave recognizes the type
and renders it as a timestamp regardless of nesting context
(`how-do-i-render-python-datetime-values-i.mdx`).
- Confirm `evaluation.Evaluate(dataset_id="my_dataset_id")` reflects the
current evaluation API (capitalization and `dataset_id` argument) and
that `WEAVE_CLIENT_PARALLELISM` / `settings={"client_parallelism": 100}`
are the current canonical names (`long-eval-clean-up-times.mdx`).
- Confirm `to_dict` is the canonical method name Weave looks for during
serialization, and that "dictionary representation" is more accurate
than "dictionary of strings" (`trace-data-is-truncated.mdx`).
- Resolve API naming inconsistency in
`trace-data-loss-in-worker-processes.mdx`: prose mixes `client.flush()`
/ `client.finish()` with `weave.flush()` / `weave.finish()`. Confirm
which are aliases, distinct, or canonical, and align throughout. Also
verify that `weave.init()` supports context-manager semantics with
auto-flush on exit, and that calling `weave.init()` inside
`process_task` is the recommended Celery pattern.
- Verify the `pageSize` boundary in `trace-pages-load-slowly.mdx:14`:
the prose says "less than the maximum of `100`" while the UI section
lists `100` as valid. Confirm whether `100` itself is allowed and reword
(e.g., "no greater than `100`").
- Verify that Weave's network activity still runs on a background thread
in the current SDK — the load-bearing claim in
`will-weave-affect-my-function-s-executio.mdx`.
- Verify PIL's "keeps file descriptors open while the program runs"
claim is still accurate for current Weave versions
(`os-errors-too-many-open-files.mdx`).
- Confirm the documented defaults and units in
`server-response-caching.mdx`: whether `WEAVE_SERVER_CACHE_SIZE_LIMIT =
1000000000` is "1 GB" or "~0.93 GiB"; the `~4 MB per running client` WAL
ceiling (and what "running client" means — process, thread, or
connection); and whether the 32 KB minimum main database file size is
platform-specific.
- Confirm the pairwise-evaluation workaround in
`what-is-pairwise-evaluation-and-how-do-i.mdx` is still current — has
the planned first-class API shipped since this article was written?
- Confirm whether "Op" (capitalized) or "function" is the canonical
Weave term, and align titles, body, and code styling consistently across
`what-information-does-weave-capture-for.mdx` and
`will-weave-affect-my-function-s-executio.mdx`.
- Confirm the "might capture" phrasing in
`what-information-does-weave-capture-for.mdx` for *System information*,
*Client information*, and *Derived information*: is capture conditional
(opt-in/opt-out, redaction) or always-on? Update phrasing accordingly.
Also confirm the *Op call hierarchy* claim about non-Op intermediate
functions still matches current behavior.
### Missing content — verification, prerequisites, and edge cases
- Add verification guidance across articles that currently lack it: how
to confirm code/system/client info capture is actually disabled
(`how-can-i-disable-*` trio); cache hit/miss signals after enabling
server response caching (`server-response-caching.mdx`); what the trace
UI shows after adding `to_dict` (`trace-data-is-truncated.mdx`);
confirmation that traces flushed before worker exit
(`trace-data-loss-in-worker-processes.mdx`); expected output of the
pairwise evaluation example
(`what-is-pairwise-evaluation-and-how-do-i.mdx`); how to confirm the new
`ulimit -n` took effect (`os-errors-too-many-open-files.mdx`); and
expected log/timing output after flushing or raising parallelism
(`long-eval-clean-up-times.mdx`).
- Add or link prerequisites: Weave SDK version / cache prerequisites
(`server-response-caching.mdx`); cross-platform guidance for `ulimit -n`
(POSIX-only) and how to make the change persistent (rc files, `launchctl
limit maxfiles`, `/etc/security/limits.conf`) in
`os-errors-too-many-open-files.mdx`; pointers to Weave installation, an
existing W&B project, or a worker framework before the snippet in
`trace-data-loss-in-worker-processes.mdx`; and a Weave tracing intro
link for first-time readers of `trace-data-is-truncated.mdx`.
- Document side effects and edge cases: what disabling
client/code/system info capture loses (debuggability, missing trace
context); naive-`datetime` behavior in
`how-do-i-render-python-datetime-values-i.mdx`; troubleshooting for
cases where `to_dict` doesn't resolve truncation (large dicts, nested
unserializable objects); timeout / exception behavior of `flush()` and
`finish()` and whether the same pattern applies to Lambda, Cloud Run,
and notebooks (`trace-data-loss-in-worker-processes.mdx`); and whether
`client.flush()` is safe to call multiple times or in async contexts
(`long-eval-clean-up-times.mdx`).
- Fill in `server-response-caching.mdx` gaps: define "idempotent
requests" in Weave's context; document default cache-directory location
per OS and cleanup guidance; describe cache invalidation and any manual
flush mechanism; describe behavior when `WEAVE_SERVER_CACHE_SIZE_LIMIT`
is exceeded (LRU eviction? write rejection?); and document concurrency
expectations when multiple clients share a `WEAVE_SERVER_CACHE_DIR`.
- Add a one-line motivation for *why* a reader would disable system info
capture (privacy, sensitive environment data, performance) in
`how-can-i-disable-system-information-cap.mdx`.
- Add a minimal code example for the `datetime` + `tzinfo` pattern in
`how-do-i-render-python-datetime-values-i.mdx`.
- Add guidance on when flushing alone suffices versus when to also
increase parallelism in `long-eval-clean-up-times.mdx`, and consider
noting tradeoffs of high parallelism (memory pressure, server-side rate
limits) and whether `100` is a ceiling or illustrative.
- Consider a code-side alternative in
`os-errors-too-many-open-files.mdx` (closing PIL `Image` objects
explicitly or using a context manager) for users who can't raise system
limits.
- Confirm whether `pageSize` is present in the URL by default or must be
appended (`trace-pages-load-slowly.mdx:14`); a short example URL would
remove the ambiguity.
- Add quantitative context to
`will-weave-affect-my-function-s-executio.mdx`: order-of-magnitude
overhead, name/link Weave's background-thread async logging mechanism,
and document any user-facing API to control or flush the exit-time pause
(e.g., `weave.finish()` / `flush()`).
### Cross-linking and terminology
- Cross-link related articles: from
`how-can-i-disable-system-information-cap.mdx` to the broader "what
information does Weave capture" article; from
`what-information-does-weave-capture-for.mdx` inline to the three
`how-can-i-disable-*` articles, plus *Op versioning* and a *Runs* link
for the `wandb` Run context bullet; from
`trace-data-loss-in-worker-processes.mdx` add a one-line orientation for
the existing links to `/support/weave/articles/long-eval-clean-up-times`
and `/weave/guides/tracking/write-ahead-log`; and cross-link `trace
metadata` and `LLM inputs/outputs` references in
`how-is-weave-data-ingestion-calculated.mdx`.
- Confirm product naming on first mention in
`how-is-weave-data-ingestion-calculated.mdx` ("Weave" vs. "W&B Weave")
and that neighboring billing/metering docs use consistent "ingested"
terminology.
- Consider hyphenating the frontmatter `title:` of
`long-eval-clean-up-times.mdx` from "Long eval clean up times" to "Long
eval clean-up times" — confirm URL/navigation impact before changing.
- FAQ title convention (preserved intentionally, flagged for site-wide
decision): the "How can I…?" interrogative pattern with trailing `?`
deviates from Google Developer Style Guide heading guidance but is
consistent across `support/weave/articles/`. If standardization is
desired, it should be done as a directory-wide pass with redirect
handling, not per-file. Similarly, the ` - ` separator between bold
label and definition in `what-information-does-weave-capture-for.mdx`
could be standardized to `:` or an em dash across support articles.
- `server-response-caching.mdx`: confirm Pass 7's removal of the "future
default behavior" line is acceptable; if a roadmap commitment exists,
restore it with a specific version or date.
- Consider whether `how-can-i-disable-client-information-cap.mdx` should
be retitled to "client info" for consistency with the SDK key
(`capture_client_info`) and UI tag ("Client Info").
## How to review
- Each file's changes are style edits only. Compare side-by-side and
flag any that change technical meaning.
- Approve and merge to accept the edits, or close to reject them.
---------
Co-authored-by: johndmulhausen <5439615+johndmulhausen@users.noreply.github.com>1 parent d8eb8df commit d033e71
24 files changed
Lines changed: 108 additions & 91 deletions
File tree
- support/weave
- articles
- tags
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
13 | 17 | | |
14 | 18 | | |
15 | 19 | | |
| |||
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
23 | | - | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
24 | 30 | | |
25 | | - | |
| 31 | + | |
26 | 32 | | |
27 | | - | |
| 33 | + | |
28 | 34 | | |
29 | | - | |
| 35 | + | |
30 | 36 | | |
31 | 37 | | |
32 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
| 54 | + | |
| 55 | + | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | | - | |
60 | | - | |
| 59 | + | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
0 commit comments