Commit d8eb8df
authored
style: apply /style-guide pass to models/automations (#2684)
## Summary
This PR applies the `/style-guide` skill (Google Developer Style Guide +
CoreWeave conventions) to the `models/automations` section. The run was
fully automated — no technical content changes were intended.
## Files edited
- `models/automations/api.mdx`
- `models/automations/automation-events.mdx`
- `models/automations/create-automations.mdx`
- `models/automations/create-automations/slack.mdx`
- `models/automations/create-automations/webhook.mdx`
- `models/automations/project-automation-tutorial.mdx`
- `models/automations/registry-automation-tutorial.mdx`
- `models/automations/tutorial.mdx`
- `models/automations/view-automation-history.mdx`
## Recommendations for technical review
### Prerequisites
- Consolidate implicit role and permissions prerequisites (team admin,
Registry admin, W&B admin, IAM, Python tooling/`wandb login`) into
explicit **Prerequisites** sections in `create-automations.mdx`,
`create-automations/webhook.mdx`, `project-automation-tutorial.mdx`,
`registry-automation-tutorial.mdx`, and `view-automation-history.mdx`.
- In `create-automations.mdx`, confirm the role-requirement asymmetry
between the Registry tab (no admin restatement) and the Project tab
("W&B admin" restated) for view/manage flows.
- In `tutorial.mdx`, surface shared prerequisites (W&B account, project,
Slack workspace, webhook endpoint) on the hub page instead of only
inside each sub-tutorial.
- In `automation-events.mdx:34`, consider a prerequisite or
cross-reference for readers landing directly on the Registry webhook
section.
- In `create-automations/webhook.mdx`, consolidate the implicit prereqs
(roles, an existing W&B secret, access to **Team Settings**) into a
single block.
- In `tutorial.mdx`, surface the **Enterprise Cloud** tier requirement
alongside the **Requirements** list rather than only in the
`EnterpriseCloudOnly` callout.
- In `registry-automation-tutorial.mdx`, flag a minimum `wandb` Python
SDK version for `api.artifact_collection`, `collection.versions()`, and
`version.aliases.append`.
- In `view-automation-history.mdx:12`, verify the `W&B Self-Managed
v0.75.0` minimum version is still accurate and consider moving it into a
Prerequisites section; also document which roles can view automation
history.
### Verification steps
- Add expected-outcome cues across procedures so readers can confirm
success: where a new automation appears in the UI after **Create
automation** (`create-automations.mdx`,
`create-automations/webhook.mdx`, `tutorial.mdx`), what a successful
webhook test looks like (`create-automations/webhook.mdx`), and what the
test Slack message contains (sender, formatting, fields) in
`project-automation-tutorial.mdx`.
- In `api.mdx`, the Note says `list`, `get`, and `delete` "might still
work" — add a minimal example or link into the Python API reference so
readers can attempt them.
- In `automation-events.mdx:165-167`, add an example or
expected-behavior description for run-level evaluation (per-run windows,
max once per 24 hours) so users can verify firing.
- In `create-automations.mdx`, verify the literal Slack handoff message
(`[YOUR-SLACK-HANDLE] added an integration to this channel: Weights &
Biases`) against actual Slack output.
- In `create-automations/webhook.mdx`, clarify what a successful vs.
failed response from the W&B-posted response looks like in the
troubleshooting flow.
- In `registry-automation-tutorial.mdx`, point readers to an in-product
verification path (e.g., the **Automations** tab run history) and add
brief troubleshooting guidance for common failure modes (alias regex
mismatch, webhook auth failure, scope confusion).
- In `view-automation-history.mdx`, walk both Tab procedures (Registry
and Project) in the UI to confirm click paths, tab names ("Automations
history" vs. "History"), the **Last execution** column label, the
`collection-automation-execution-icon.png` icon, and whether the
Registry **Last execution** timestamp navigates to the **Automations
history** tab or a separate detail view. Also confirm whether the single
Project-tab step should be split.
### Technical accuracy
- In `api.mdx`, confirm the Note's framing (create/update fail due to
client-side feature check) still matches engineering guidance, that
`WB-34263` is the correct internal reference, and whether exposing that
internal Jira ID publicly is acceptable.
- In `automation-events.mdx:57-60`, decide whether the
`MultiTenantCloudOnly` availability notice and the **Killed** behavioral
caveat belong in the same `<Note>` or should be split.
- In `automation-events.mdx:75`, confirm whether the "every 15 seconds"
system metrics interval is configurable or version-dependent and
consider linking the system metrics reference.
- In `automation-events.mdx:109`, consider a diagram or worked example
showing how the current and prior windows align.
- In `create-automations.mdx`, confirm the side effects on dependent
automations when a Slack destination is deleted, and document whether
the run-filter username field accepts entity usernames vs. display
names.
- In `create-automations/webhook.mdx`, validate the rewording of "the
webhook's service determines your webhook's requirements"; confirm that
nested artifact metadata is genuinely unsupported via
`${artifact_metadata.<KEY>}`; decide between "GHA workflow" and the
expanded "GitHub Actions workflow"; confirm **Bot User OAuth Token** is
still the recommended secret type for the legacy Slack webhook flow and
whether it should be bolded as a UI label; confirm whether the Bash
shell script accurately mirrors W&B's actual `POST` or should be flagged
as an approximation.
- In `project-automation-tutorial.mdx`, verify whether the commented-out
Python tab (blocked by WB-34263) should be restored, removed, or
updated, and confirm the regression is still open.
- In `registry-automation-tutorial.mdx`, confirm whether the **Alias
regex** field accepts true regex or a literal/glob (the example
`production` is ambiguous); confirm whether registry-wide scope is
achievable via the Python SDK (vs. the commented
`OnAddArtifactAlias(scope=collection, ...)`); verify that
`next(collection.versions())` yields the newest version first; and
confirm `run.wait()` is still the recommended pattern vs.
`artifact.wait()` or context-manager finalization.
- In `tutorial.mdx`, decide whether the unused imports
`TutorialDiagramProject` and `TutorialDiagramRegistry` should be
rendered or removed.
- In `view-automation-history.mdx:21`, confirm the `#execution-status`
anchor target is intended (vs. `#execution-details`); in line 51,
confirm whether a **Failed** automation always halts entirely or may
have partially completed actions; in lines 50–52, confirm
Finished/Failed/Pending are the complete status set (no Running,
Cancelled, Retrying); in line 59, verify event-type strings ("New
artifact version", "Run completed") match exact UI labels.
### Missing content
- In `api.mdx`, add a one-sentence definition of "W&B automations"
rather than relying on the overview link, and confirm the hidden HTML
comment's restoration plan (list/get/create/update/delete examples +
Automations tutorial notebook from `wandb/examples` PR 618) is still
accurate; if the SDK fix is imminent, consider a temporary redirect to
`/models/automations/create-automations`.
- In `automation-events.mdx`, document boundary behavior during the
change-threshold warm-up before the prior window is fully populated
(line 104), and confirm whether the z-score window has a minimum run
count before evaluation begins (line 131).
- In `create-automations.mdx`, preview the nested numbered list in the
Project tab (lines 80–86) to confirm Mintlify renders sub-steps
correctly; if not, flatten to a single numbered list with embedded
prose.
- In `create-automations/webhook.mdx`, re-validate the cross-reference
in the Secret step that points to a "next step" about specifying the
secret; confirm the Slack notifications "new Slack integration" link
target `/models/automations/create-automations/slack`; reformat YAML
(`on/repository_dispatch`) and JSON (`client_payload`) examples for
consistent indentation; convert angle-bracket placeholders
(`<wandb-user>`, `<entity>`, `<registered_model_name>`, `<alias>`) in
the template-string output block to the `[ALL-CAPS-HYPHENATED]`
convention; and flatten the four-level-deep nesting under "Choose the
event to watch for."
- In `project-automation-tutorial.mdx`, add a brief link or note
distinguishing "failed" runs from other terminal states (crashed,
killed) since the filter depends on it.
- In `registry-automation-tutorial.mdx`, add **Clean up** or **Next
steps** with teardown guidance (removing the test alias, disabling the
automation); track restoring the commented Python tab once WB-34263
ships; confirm whether the existing payload-variables link is
sufficient.
- In `tutorial.mdx`, verify that the `<AutomationsMentalModel/>` snippet
provides sufficient framing; if not, add a brief "Who this is for" or
"Before you begin" pointer on the hub.
- In `view-automation-history.mdx`, document conditions/typical duration
for the **Pending** status (and what to do if stuck); clarify which
event types include user attribution for the "User who triggered the
event (if applicable)" line; add a parent description sentence for
**Result information** for parallel structure; document the retention
period for execution history; add guidance (link to troubleshooting or
retry) for failed executions; and confirm or replace the **Next steps**
link to "Create a secret," which is not clearly related to automation
history.
## How to review
- Each file's changes are style edits only. Compare side-by-side and
flag any that change technical meaning.
- Approve and merge to accept the edits, or close to reject them.1 parent f516163 commit d8eb8df
9 files changed
Lines changed: 213 additions & 139 deletions
File tree
- models/automations
- create-automations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
| 7 | + | |
| 8 | + | |
6 | 9 | | |
7 | | - | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
| 15 | + | |
| 16 | + | |
12 | 17 | | |
13 | 18 | | |
14 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | | - | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | | - | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
| 20 | + | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
| 24 | + | |
21 | 25 | | |
22 | | - | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
28 | | - | |
| 32 | + | |
| 33 | + | |
29 | 34 | | |
30 | 35 | | |
| 36 | + | |
31 | 37 | | |
32 | 38 | | |
33 | 39 | | |
| 40 | + | |
34 | 41 | | |
35 | 42 | | |
36 | 43 | | |
37 | | - | |
38 | | - | |
| 44 | + | |
| 45 | + | |
39 | 46 | | |
40 | 47 | | |
41 | | - | |
| 48 | + | |
| 49 | + | |
42 | 50 | | |
43 | 51 | | |
44 | 52 | | |
45 | 53 | | |
46 | | - | |
| 54 | + | |
47 | 55 | | |
48 | 56 | | |
49 | 57 | | |
| |||
63 | 71 | | |
64 | 72 | | |
65 | 73 | | |
66 | | - | |
| 74 | + | |
67 | 75 | | |
68 | 76 | | |
69 | 77 | | |
70 | 78 | | |
71 | | - | |
| 79 | + | |
| 80 | + | |
72 | 81 | | |
73 | 82 | | |
74 | 83 | | |
| |||
79 | 88 | | |
80 | 89 | | |
81 | 90 | | |
82 | | - | |
| 91 | + | |
83 | 92 | | |
84 | 93 | | |
85 | 94 | | |
86 | 95 | | |
87 | 96 | | |
88 | 97 | | |
89 | | - | |
| 98 | + | |
| 99 | + | |
90 | 100 | | |
91 | 101 | | |
92 | 102 | | |
93 | 103 | | |
94 | | - | |
| 104 | + | |
95 | 105 | | |
96 | | - | |
| 106 | + | |
97 | 107 | | |
98 | 108 | | |
99 | 109 | | |
| |||
102 | 112 | | |
103 | 113 | | |
104 | 114 | | |
105 | | - | |
| 115 | + | |
106 | 116 | | |
107 | 117 | | |
108 | 118 | | |
| |||
113 | 123 | | |
114 | 124 | | |
115 | 125 | | |
116 | | - | |
| 126 | + | |
117 | 127 | | |
118 | 128 | | |
119 | 129 | | |
120 | 130 | | |
121 | 131 | | |
122 | 132 | | |
123 | 133 | | |
124 | | - | |
| 134 | + | |
125 | 135 | | |
126 | 136 | | |
127 | 137 | | |
128 | | - | |
129 | | - | |
130 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
131 | 141 | | |
132 | | - | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
133 | 145 | | |
134 | | - | |
135 | 146 | | |
136 | 147 | | |
137 | 148 | | |
138 | 149 | | |
139 | 150 | | |
140 | 151 | | |
| 152 | + | |
141 | 153 | | |
142 | 154 | | |
143 | | - | |
144 | | - | |
145 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
146 | 163 | | |
147 | | - | |
148 | 164 | | |
149 | 165 | | |
150 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
151 | 169 | | |
152 | 170 | | |
153 | 171 | | |
| |||
0 commit comments