Skip to content

fix(operator): Slim out default rbac SA Tokens and secrets access#193

Draft
casey-coreweave wants to merge 2 commits into
v2from
cabernathy/minimal_app_rbac
Draft

fix(operator): Slim out default rbac SA Tokens and secrets access#193
casey-coreweave wants to merge 2 commits into
v2from
cabernathy/minimal_app_rbac

Conversation

@casey-coreweave
Copy link
Copy Markdown
Contributor

@casey-coreweave casey-coreweave commented May 29, 2026

  • Removed default app Role access to Secrets and narrowed it to only get on namespaces
  • Changed app service account to automountServiceAccountToken: false

WARNING This needs better testing

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22be64f9-c04f-4297-bdef-fedbb3116900

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cabernathy/minimal_app_rbac

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@casey-coreweave casey-coreweave marked this pull request as draft May 29, 2026 18:00
Copy link
Copy Markdown
Contributor

@danielpanzella danielpanzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should talk about this, but as is it will break a bunch of things in the api service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants