chore: add SPDX headers to build/release scripts#61
Draft
rgao-coreweave wants to merge 1 commit into
Draft
Conversation
Bring the 5 author-written scripts under scripts/ in line with the SPDX
header convention used everywhere else in src/, tests/, hooks/. Each
file gains the 3-line block specified by .reuse/templates/default_template.jinja2:
SPDX-FileCopyrightText: 2026 CoreWeave, Inc.
SPDX-License-Identifier: MIT
SPDX-PackageName: weave-claude-plugin
Generated via the canonical command from CONTRIBUTING.md:
reuse annotate --license MIT --copyright 'CoreWeave, Inc.' \
--year 2026 --template default_template --skip-existing $FILE
Note: this is hygiene, not a compliance fix. `reuse lint` was already
clean before this change because REUSE.toml declares a bulk annotation
covering all files via `path = "**"`. The 5 scripts were simply outliers
relative to the rest of the repo's physical-header convention.
Intentionally skipped:
- src/version.mjs — auto-generated by the release-bump workflow; a
physical header would either be clobbered or break the automation.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the 3-line SPDX header (per
.reuse/templates/default_template.jinja2) to the 5 author-written scripts underscripts/that lacked physical headers, matching the convention used everywhere else insrc/,tests/,hooks/.Files touched:
scripts/install-git-hooks.mjsscripts/build/copy-version-module.mjsscripts/release/bump-version.mjsscripts/release/update-marketplace-sha.mjsscripts/release/version-module-utils.mjsGenerated via the canonical command from
CONTRIBUTING.md:This is hygiene, not a compliance fix
reuse lintwas clean before this change, becauseREUSE.tomldeclares a bulk annotation covering every file viapath = "**". These 5 scripts were simply visual outliers relative to the rest of the repo's physical-header convention.Intentionally skipped
src/version.mjs— auto-generated by the release-bump workflow (scripts/release/bump-version.mjs); explicitly marked "maintained by release automation. Do not edit manually." A physical header here would either get clobbered on the next bump or require teaching the bump script to preserve it.tests/fixtures/fake-weave-plugin-bin/weave-claude-plugin— already gained its missingSPDX-PackageNamein fix: detect and recover from stale daemon sockets #53 (commit3bb871f).CI gap (separate question, not addressed here)
There is no SPDX/REUSE check in CI today —
format-and-lint.yamlrunsnpm run check(build + test + secrets scan) but doesn't invokereuse lint. Worth noting:reuse lintwould catch a brand-new file that isn't covered byREUSE.tomland has no header. It would not have caught the partial-header issue chance-wnb flagged on fix: detect and recover from stale daemon sockets #53 (missingSPDX-PackageName), because partial headers are still REUSE-spec compliant.src/,tests/,hooks/, orscripts/has anySPDX-line, it must have all three from the template") would catch the partial-header case.Happy to follow up with either or both in a separate PR — flagged here for visibility rather than scope-creeping this one.
Test plan
reuse lint— 37/37 files compliant, spec 3.3npm run build— clean (the SPDX header on the build script itself didn't break the build pipeline)npm test— 8/8 pass🤖 Generated with Claude Code