chore(weave_ts): Use types provided by @openai/agents#6970
Open
drtangible wants to merge 3 commits into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b7c02b9581d976fa23460e68d1083e10221a85b5 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
drtangible
commented
May 26, 2026
| from_agent?: string; | ||
| to_agent?: string; | ||
| }; | ||
| export type {CustomSpanData, Trace, TracingProcessor} from '@openai/agents'; |
Contributor
Author
There was a problem hiding this comment.
Note: eventually we can just use types directly from the library, just keeping change minimal w/this PR.
Collaborator
There was a problem hiding this comment.
Just want to make sure: will this incur cost for anyone not using openai?
Base automatically changed from
05-26-chore_weave_ts_remove_unnecessary_type_assertions_in_openai.agents.ts
to
master
May 26, 2026 23:03
drtangible
force-pushed
the
05-26-chore_weave_ts_use_types_provided_by_openai_agents
branch
from
0f27ffb to
46f800d
Compare
This was referenced May 27, 2026
drtangible
force-pushed
the
05-26-chore_weave_ts_use_types_provided_by_openai_agents
branch
from
cdde2d1 to
70eca1a
Compare
andrewtruong
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We manually maintain some duplicated types for 3rd party libraries. This can mask type issues / bugs that can be caught by pointing to the library-provided types via
devDependencies.This change removes some of the duplicated
@openai/agentstypes.