Skip to content

fix(weave_ts): Use types provided by @earendil-works/pi-*#6985

Draft
drtangible wants to merge 2 commits into
05-27-use_types_provided_by_openai_agents-realtimefrom
05-27-fix_weave_ts_use_types_provided_by_earendil-works_pi-_
Draft

fix(weave_ts): Use types provided by @earendil-works/pi-*#6985
drtangible wants to merge 2 commits into
05-27-use_types_provided_by_openai_agents-realtimefrom
05-27-fix_weave_ts_use_types_provided_by_earendil-works_pi-_

Conversation

@drtangible
Copy link
Copy Markdown
Contributor

@drtangible drtangible commented May 27, 2026

Description

  • We manually maintain some duplicated types for 3rd party libraries. This can mask type issues / bugs that can be caught by pointing to the library-provided types via devDependencies.

  • This change removes some of the duplicated @earendil-works/pi-* library types.

  • Using the actual types surfaced some type errors in the implementation of the pi-coding-agent SDK integration. Updating those as well.

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 27, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​earendil-works/​pi-coding-agent@​0.76.06310010096100
Added@​earendil-works/​pi-ai@​0.76.07110010096100
Added@​earendil-works/​pi-agent-core@​0.76.07210010096100

View full report

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 27, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Install-time scripts: npm @google/genai during preinstall

Install script: preinstall

Source: echo 'preinstall: no-op'

From: sdks/node/pnpm-lock.yamlnpm/@earendil-works/pi-ai@0.76.0npm/@google/genai@1.52.0

ℹ Read more on: This package | This alert | What is an install script?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@google/genai@1.52.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wandbot-3000
Copy link
Copy Markdown

wandbot-3000 Bot commented May 27, 2026

@drtangible drtangible force-pushed the 05-27-use_types_provided_by_openai_agents-realtime branch from 6751a87 to badab4b Compare May 28, 2026 14:31
@drtangible drtangible force-pushed the 05-27-fix_weave_ts_use_types_provided_by_earendil-works_pi-_ branch from 53cd1b3 to 3d5b0e1 Compare May 28, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant