chore(weave): remove dead actions_execute_batch endpoint and ActionSpec#6987
Open
gtarpenning wants to merge 2 commits into
Open
chore(weave): remove dead actions_execute_batch endpoint and ActionSpec#6987gtarpenning wants to merge 2 commits into
gtarpenning wants to merge 2 commits into
Conversation
The `/actions/execute_batch` endpoint and its `ActionSpec` / LLM Judge / contains-words executor were the Nov 2024 "Online Evals Part 1" stub. The async Part 4 never landed, and the production online-evals path now goes through `/calls/score` -> Kafka -> call_scoring_worker, which doesn't touch this code. Frontend has no live caller. Safe to remove. Drops: - weave/trace_server/actions_worker/ (dispatcher + judge/contains-words impls) - weave/trace_server/interface/builtin_object_classes/actions.py (ActionSpec) - actions_execute_batch method from interface + CH + sqlite + adapter + both remote bindings + test fixtures - ActionsExecuteBatchReq/Res request models - ActionSpec registration in builtin_object_registry + base_objects export - tests/trace/test_actions_lifecycle.py - tests/integrations/litellm/test_actions_lifecycle_llm_judge.py - stale generated_base_object_class_schemas.json (unreferenced legacy file) Regenerated generated_builtin_object_class_schemas.json (12 objects, was 13).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=80cd502de255675196c3719fb9bdc7b74a5ea16c |
andrewtruong
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/actions/execute_batchand theActionSpec/ LLM Judge / contains-words executor were the Nov 2024 "Online Evals Part 1" stub (chore(weave): Online Evals Part 1: Backend support for on-demand LLM Judges #2882). Part 4 never landed./calls/score-> Kafka ->call_scoring_worker, which does not touch this code.NewScorerDraweris unconditionally filtered out andLLMJudgesTabis not mounted onScorersPage. Companion core PR (wandb/core) removes the frontend dead code, the FastAPI route, and the worker wrappers.Drops:
weave/trace_server/actions_worker/(dispatcher + llm_judge + contains_words)weave/trace_server/interface/builtin_object_classes/actions.py(ActionSpec + configs)actions_execute_batchfrom interface + CH + sqlite + adapter + remote bindings + test fixturesActionsExecuteBatchReq/ActionsExecuteBatchResbuiltin_object_registry+weave.trace.base_objectsexporttests/trace/test_actions_lifecycle.py,tests/integrations/litellm/test_actions_lifecycle_llm_judge.pygenerated_base_object_class_schemas.json(unreferenced legacy artifact)Regenerated
generated_builtin_object_class_schemas.json(12 objects, down from 13).Customer DBs may contain historical
ActionSpecrows. They will no longer round-trip through the SDK's typedBUILTIN_OBJECT_REGISTRYbut will still be readable as plain objects.Testing
imported all touched servers (CH, sqlite, adapter, remote_http, stainless) and confirmed
ActionSpecno longer in registry,ActionsExecuteBatchReqno longer on tsi,actions_execute_batchno longer on CH server. ruff clean.