fix(weave): support eval_results filtering on inputs#7006
Open
domphan-wandb wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
b011963 to
e374861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few issues with filtering and sorting capabilities on imperatively logged evals because they don't have an actual dataset.
Problem
Filtering and sorting on
inputs.*was returning empty results whose row_digest had no matching row intable_rows.resolved_inputswithCOALESCE(tr.val_dump, JSONExtractRaw( inputs_dump, 'example'))tris the result of a LEFT JOIN on the row digest.'', becauseval_dumpis a non nullable string.COALESCE will always return the empty string, which makes sorting and filtering broken on inputs.
To fix this, the PR adds
nullIfcalls on theval_dumpso that the COALESCE can actually fallthrough to the example.Testing
How was this PR tested?