Skip to content

fix(weave): support eval_results filtering on inputs #7006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domphan-wandb wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

fix(weave): support eval_results filtering on inputs #7006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/trace_server/query_builder/test_eval_results_query_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def test_cte_chain_calls_merged() -> None:
predict_and_score_calls_resolved.eval_call_id AS eval_call_id,
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(page_resolved_inputs.val_dump, JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
COALESCE(nullIf(page_resolved_inputs.val_dump, ''), JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
FROM predict_and_score_calls_resolved
INNER JOIN page_digests ON predict_and_score_calls_resolved.row_digest = page_digests.row_digest
LEFT JOIN page_resolved_inputs ON page_resolved_inputs.digest = predict_and_score_calls_resolved.row_digest
Expand Down Expand Up @@ -184,7 +184,7 @@ def test_cte_chain_calls_complete() -> None:
predict_and_score_calls_resolved.eval_call_id AS eval_call_id,
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(page_resolved_inputs.val_dump, JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
COALESCE(nullIf(page_resolved_inputs.val_dump, ''), JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
FROM predict_and_score_calls_resolved
INNER JOIN page_digests ON predict_and_score_calls_resolved.row_digest = page_digests.row_digest
LEFT JOIN page_resolved_inputs ON page_resolved_inputs.digest = predict_and_score_calls_resolved.row_digest
Expand Down Expand Up @@ -322,7 +322,7 @@ def test_cte_chain_sort_and_multi_eval_filters() -> None:
predict_and_score_calls_resolved.eval_call_id AS eval_call_id,
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(page_resolved_inputs.val_dump, JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
COALESCE(nullIf(page_resolved_inputs.val_dump, ''), JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
FROM predict_and_score_calls_resolved
INNER JOIN page_digests ON predict_and_score_calls_resolved.row_digest = page_digests.row_digest
LEFT JOIN page_resolved_inputs ON page_resolved_inputs.digest = predict_and_score_calls_resolved.row_digest
Expand Down Expand Up @@ -457,7 +457,7 @@ def test_eval_filter_infers_cast_for_typed_literal_without_convert() -> None:
predict_and_score_calls_resolved.eval_call_id AS eval_call_id,
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(page_resolved_inputs.val_dump, JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
COALESCE(nullIf(page_resolved_inputs.val_dump, ''), JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
FROM predict_and_score_calls_resolved
INNER JOIN page_digests ON predict_and_score_calls_resolved.row_digest = page_digests.row_digest
LEFT JOIN page_resolved_inputs ON page_resolved_inputs.digest = predict_and_score_calls_resolved.row_digest
Expand Down Expand Up @@ -556,7 +556,7 @@ def test_full_query_calls_merged() -> None:
predict_and_score_calls_resolved.eval_call_id AS eval_call_id,
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(page_resolved_inputs.val_dump, JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
COALESCE(nullIf(page_resolved_inputs.val_dump, ''), JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
FROM predict_and_score_calls_resolved
INNER JOIN page_digests ON predict_and_score_calls_resolved.row_digest = page_digests.row_digest
LEFT JOIN page_resolved_inputs ON page_resolved_inputs.digest = predict_and_score_calls_resolved.row_digest
Expand Down Expand Up @@ -682,7 +682,7 @@ def test_full_query_calls_complete() -> None:
predict_and_score_calls_resolved.eval_call_id AS eval_call_id,
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(page_resolved_inputs.val_dump, JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
COALESCE(nullIf(page_resolved_inputs.val_dump, ''), JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')) AS resolved_inputs
FROM predict_and_score_calls_resolved
INNER JOIN page_digests ON predict_and_score_calls_resolved.row_digest = page_digests.row_digest
LEFT JOIN page_resolved_inputs ON page_resolved_inputs.digest = predict_and_score_calls_resolved.row_digest
Expand Down
4 changes: 2 additions & 2 deletions weave/trace_server/query_builder/eval_results_query_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def build_predict_and_score_calls_resolved_cte(
SELECT
predict_and_score_calls.*,
COALESCE(
tr.val_dump,
nullIf(tr.val_dump, ''),
JSONExtractRaw(predict_and_score_calls.inputs_dump, 'example')
) AS resolved_inputs
FROM predict_and_score_calls
Expand Down Expand Up @@ -412,7 +412,7 @@ def build_page_rows_cte() -> str:
predict_and_score_calls_resolved.row_digest AS row_digest,
page_digests.row_order AS row_order,
COALESCE(
page_resolved_inputs.val_dump,
nullIf(page_resolved_inputs.val_dump, ''),
JSONExtractRaw(predict_and_score_calls_resolved.inputs_dump, 'example')
) AS resolved_inputs
FROM predict_and_score_calls_resolved
Expand Down
Loading