Skip to content

Commit e49d29f

Browse files
committed
fix(dark-mode): fix 5 component issues in dark mode
- Descriptions: remove hardcoded grey table background, use transparent - Segmented: add theme tokens for track and active item backgrounds - Tag: replace hardcoded #fff in "New Tag" demo with CSS variable - Cascader: add theme tokens for input bg/border/dropdown, replace Unicode ▾ with ArrowDown icon component (matching Select) - Table: add theme tokens for header bg, border, and hover colors
1 parent 4337ae1 commit e49d29f

6 files changed

Lines changed: 48 additions & 4 deletions

File tree

components/cascader/__tests__/__snapshots__/cascader.test.tsx.snap

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,16 @@ exports[`<Cascader /> should match the snapshot 1`] = `
1616
<span
1717
class="ty-cascader__arrow"
1818
>
19-
19+
<svg
20+
height="10"
21+
viewBox="0 0 1024 1024"
22+
width="10"
23+
>
24+
<path
25+
d="M472.064 751.552 72.832 352.32c-22.08-22.08-22.08-57.792 0-79.872 22.016-22.016 57.792-22.08 79.872 0L512 631.744l359.296-359.296c22.016-22.016 57.792-22.08 79.872 0 22.08 22.08 22.016 57.792 0 79.872l-399.232 399.232C529.856 773.568 494.144 773.568 472.064 751.552z"
26+
fill="currentcolor"
27+
/>
28+
</svg>
2029
</span>
2130
</div>
2231
</div>

components/cascader/cascader.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { createPortal } from 'react-dom';
33
import classNames from 'classnames';
44
import { ConfigContext } from '../config-provider/config-context';
55
import { getPrefixCls } from '../_utils/general';
6+
import { ArrowDown } from '../_utils/components';
67
import { CascaderProps, CascaderOption, CascaderValue } from './types';
78

89
const getOptionsByValue = (
@@ -249,7 +250,7 @@ const Cascader = React.forwardRef<HTMLDivElement, CascaderProps>((props, ref) =>
249250
250251
</span>
251252
)}
252-
<span className={`${prefixCls}__arrow`}></span>
253+
<span className={`${prefixCls}__arrow`}><ArrowDown size={10} /></span>
253254
</div>
254255
{dropdown}
255256
</div>

components/descriptions/style/_index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
table-layout: fixed;
1313
box-sizing: border-box;
1414
text-align: left;
15-
background-color: var(--ty-color-bg-elevated);
15+
background-color: transparent;
1616
}
1717
}
1818

components/style/themes/_dark.scss

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,4 +355,21 @@ $dark-theme: (
355355

356356
// ---- Component-specific: Textarea ----
357357
textarea-counter-color: rgba(255, 255, 255, 0.45),
358+
359+
// ---- Component-specific: Table ----
360+
table-header-bg: #262626,
361+
table-border: #363636,
362+
table-hover: #2a2a2a,
363+
table-selected-bg: rgba(144, 101, 208, 0.1),
364+
365+
// ---- Component-specific: Segmented ----
366+
segmented-bg: #2a2a2a,
367+
segmented-active-bg: #1f1f1f,
368+
369+
// ---- Component-specific: Cascader ----
370+
cascader-bg: #1f1f1f,
371+
cascader-border: #424242,
372+
cascader-dropdown-bg: #1f1f1f,
373+
cascader-hover: #2a2a2a,
374+
cascader-selected-bg: rgba(144, 101, 208, 0.1),
358375
);

components/style/themes/_light.scss

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,4 +355,21 @@ $light-theme: (
355355

356356
// ---- Component-specific: Textarea ----
357357
textarea-counter-color: #666,
358+
359+
// ---- Component-specific: Table ----
360+
table-header-bg: #f6f9fc,
361+
table-border: #e9ecef,
362+
table-hover: #f6f9fc,
363+
table-selected-bg: rgba(110, 65, 191, 0.06),
364+
365+
// ---- Component-specific: Segmented ----
366+
segmented-bg: #e9ecef,
367+
segmented-active-bg: #fff,
368+
369+
// ---- Component-specific: Cascader ----
370+
cascader-bg: #fff,
371+
cascader-border: #d9d9d9,
372+
cascader-dropdown-bg: #fff,
373+
cascader-hover: #f5f5f5,
374+
cascader-selected-bg: rgba(110, 65, 191, 0.06),
358375
);

components/tag/demo/dynamic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Adding or removing a set of tags dynamically.
5656
)
5757
:
5858
(
59-
<Tag onClick={showInput} style={{ background: '#fff', borderStyle: 'dashed' }}>
59+
<Tag onClick={showInput} style={{ background: 'var(--ty-color-bg-container)', borderStyle: 'dashed' }}>
6060
<Icon name="plus" size={11}/> New Tag
6161
</Tag>
6262
)}

0 commit comments

Comments
 (0)