You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merge master into feat-graph-dpa2 (integrate deepmodeling#5758 dpa1 graph CUDA rework)
Master's deepmodeling#5758 restructured the NeighborGraph deployment ABI while this
PR's review batch was landing; this merge re-expresses the batch on the
new schema. Master's conventions adopted as the base:
- 13-input graph lower (atype, n_node, n_local, edge_index, edge_vec,
edge_mask, destination_order, destination_row_ptr, source_order,
source_row_ptr, fparam, aparam, charge_spin), canonicalize=True
destination-major payloads, destination_sorted validation, and the
canonical (compressed-dpa1 CUDA) export flavor.
- n_local as a first-class device input on every graph route: this
SUBSUMES this branch's 17th-input with-comm design -- the extra input
is dropped, while the all-8-comm-tensors-on-CPU placement, the
border_op explicit CUDA-stream sync, and the ago==0 preflight cache
are kept.
- n_local now also masks halo rows of the per-node outputs (owned rows
unchanged); contract tests updated.
- The rectangular-aparam ragged extension shim (_extend_graph_aparam)
is kept as a correct alternate input layout; flat (N, nda) remains
the canonical trace/export ABI.
Review-batch semantics re-grafted onto the new base:
- trace capacity from the real synthetic edge count (probe + prime
collision-free dims, export and compiled training).
- flat (N, nda) aparam ABI: trace sample slot 11, dynamic-shape spec
sharing atype's n_node_total symbol, all rectangular->flat boundaries.
- energy gate on the default-flip, now in the shared
graph_lower.model_uses_graph_lower; dense compiled key translation
stays output-agnostic.
- with-comm graph artifact: trace branch re-added to the export graph
section (master had none), nested-artifact trace now inherits
lower_kind, EnergyModel with-comm wrapper rewritten to the 13-input
base, C++ run_model_graph_with_comm and its call site moved to the
13-input pack (canonicalized payload + flat aparam via
extend_graph_aparam).
- pt_expt dpa1 call_graph regains the comm_dict pass-through (ABI
stability; forwarded to the dpmodel fallback).
Verified: graph export/metadata/with-comm suites, dpa1+dpa2 graph
lower, dpmodel graph suites, training+multitask, dos_graph,
neighbor_list, graph deepeval, dpa1 descriptor (400+ tests); C++
full rebuild + dpa1/dpa2 graph and fparam/aparam gtests (39 pass)
on regenerated 13-input fixtures.
0 commit comments