ARM compatibility#23
Merged
skbill84 merged 2 commits intowangyiqiu:masterfrom Jun 29, 2025
Merged
Conversation
Collaborator
|
Hi @John-194 , |
Contributor
Author
I tested on a Jetson. I ran DBSCAN on a point cloud on repeat without any thread restrictions. It might not crash right away, but after a few iterations, the script seg faults or freezes. There is also a related open issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM CPUs need strict memory orders. While x86 has a stronger memory model, it should not be relied upon.
Specifically, in this case,
local_botanddonecannot be relaxed for ARM; some other values could possibly be relaxed (like a simplefinished_flag), but to be on the safe side, I changed other ones too from relaxed to release/acquire.Performance-wise,
memory_order_acquireandmemory_order_releaseshould be unnoticeable on x86, while possibly adding some safety.