fix unintended dereference (seg fault)#24
Merged
skbill84 merged 1 commit intowangyiqiu:masterfrom Jun 27, 2025
Merged
Conversation
Collaborator
|
Fantastic catch! Thanks so much for digging into this. Really appreciate your thoroughness here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a rare segmentation fault.
What was happening:
grid.h
table = new tableT(cellMax*2, cellHash<dim, objT>(myHash));passes a temporarycellHash.original code:
Problem:
hashFis the temporary,empty()returns pointer tocell, which is a part of the tmp. The tmpcellgets deleted after theTableinitialization list finishes.hashF(tmp) gets copied tohashStructvia copy constructor, butempty(hashF.empty())ends up dereferenced.Fix: Initialize empty from the copy of
hashF(hashStruct). This only works after the initialization list has finished.snippet of ASAN error message: