Skip to content

Commit b674c5a

Browse files
Zexiclaude
authored andcommitted
fix: allow saving new inbound server password without validation
Validating new credentials against the currently-running server was wrong: by definition the new password won't match until the server restarts. Remove the preflight health check and rely on the existing "restart required" toast to inform the user that the change takes effect after a restart. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 7c75568 commit b674c5a

1 file changed

Lines changed: 0 additions & 25 deletions

File tree

packages/app/src/components/dialog-select-server.tsx

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -677,31 +677,6 @@ export function DialogSelectServer() {
677677
return
678678
}
679679

680-
// When credentials are changing, verify the new credentials actually work
681-
// against the currently running server before persisting them. This prevents
682-
// saving a typo that would lock the user out on the next request.
683-
const credentialsChanged = !current || current.username !== next.username || current.password !== next.password
684-
if (credentialsChanged && next.enabled && next.password) {
685-
const runtimeConfig = platform.localServerRuntimeConfig?.()
686-
const runningPort = runtimeConfig?.port ?? current?.port
687-
if (runningPort) {
688-
const testHttp: ServerConnection.HttpBase = {
689-
url: `http://localhost:${runningPort}`,
690-
username: next.username || undefined,
691-
password: next.password,
692-
}
693-
const result = await checkServerHealth(testHttp)
694-
if (!result.healthy) {
695-
showToast({
696-
variant: "error",
697-
title: language.t("common.requestFailed"),
698-
description: language.t("dialog.server.inbound.credentialInvalid"),
699-
})
700-
return
701-
}
702-
}
703-
}
704-
705680
setStore("inboundServer", "saving", true)
706681
try {
707682
await platform.setLocalServerConfig(next)

0 commit comments

Comments
 (0)